Google Git
Sign in
go/review/44454f6a837226d68c264174b72b85084f01c1a7
commit
44454f6a837226d68c264174b72b85084f01c1a7
[log]
author
Eric Lagergren <eric@ericlagergren.com>
Wed Aug 28 16:29:14 2019 -0700
committer
Josh Bleecher Snyder <josharian@gmail.com>
Sat Nov 09 00:12:09 2019 +0000
tree
d3bd91a94feebb0092729a046d43e71f661380b9
parent
85688492bf1b598c999c025b9d626ae298968a43 [diff]
git-codereview: override existing locale with LC_ALL=C

The git-codereview tool shells out to git, then parses the output.
However, because git respects a user's locale settings its output might
not be in English, confusing git-codereview.

Explicitly set the LC_ALL environment variable to the "C" locale, which
is a version of US English that should be on all machines.

Fixes golang/go#33895

Change-Id: Id06a81046dba58131fc1de602dd9add687846da1
Reviewed-on: https://go-review.googlesource.com/c/review/+/192237
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
3 files changed
tree: d3bd91a94feebb0092729a046d43e71f661380b9
  1. git-codereview/
  2. .gitattributes
  3. AUTHORS
  4. codereview.cfg
  5. CONTRIBUTING.md
  6. CONTRIBUTORS
  7. go.mod
  8. LICENSE
  9. PATENTS
  10. README.md
README.md

git-codereview

The git-codereview tool is a command-line tool for working with Gerrit.

Download/Install

The easiest way to install is to run go get -u golang.org/x/review/git-codereview. You can also manually git clone the repository to $GOPATH/src/golang.org/x/review.

Run git codereview hooks to install Gerrit hooks for your git repository.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the review repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/review:” in the subject line, so it is easy to find.