| commit | 40cba14b2608da2a4fc8d64c5e8412e9670f38e2 | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Wed Feb 05 10:12:40 2020 -0800 |
| committer | Damien Neil <dneil@google.com> | Wed Feb 05 22:49:38 2020 +0000 |
| tree | 83280820d17bced8c729b138d8b95c2654b132d6 | |
| parent | 9dd7148ccd3fde5cddae6e63af037a4bacc1e5ba [diff] |
internal/impl: fix for lazy decoding of groups Bit of a weird case in why this wasn't caught by tests: When validating extension groups, we were validating an empty buffer rather than the message content. For groups, this validation always fails due to a lack of a group end tag. We'd then skip lazy decoding of the extension field and proceed with eager decoding, which would behave correctly. Change extension validation to report an error immediately on an invalid result from the validator, which is both safe (assuming we trust the validator) and would have caught this problem (by failing to decode the extension field, rather than silently failing to eager decoding). Change-Id: Id6c2d21fb687062bc74d9eb93760a1c24a6fe883 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/217767 Reviewed-by: Joe Tsai <joetsai@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.