tree 83280820d17bced8c729b138d8b95c2654b132d6
parent 9dd7148ccd3fde5cddae6e63af037a4bacc1e5ba
author Damien Neil <dneil@google.com> 1580926360 -0800
committer Damien Neil <dneil@google.com> 1580942978 +0000

internal/impl: fix for lazy decoding of groups

Bit of a weird case in why this wasn't caught by tests: When validating
extension groups, we were validating an empty buffer rather than the
message content. For groups, this validation always fails due to a lack
of a group end tag. We'd then skip lazy decoding of the extension field
and proceed with eager decoding, which would behave correctly.

Change extension validation to report an error immediately on an invalid
result from the validator, which is both safe (assuming we trust the
validator) and would have caught this problem (by failing to decode the
extension field, rather than silently failing to eager decoding).

Change-Id: Id6c2d21fb687062bc74d9eb93760a1c24a6fe883
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/217767
Reviewed-by: Joe Tsai <joetsai@google.com>