commit | 34a9c69fcd8d9ae8d404ff3d39bd81b749a78ca1 | [log] [tgz] |
---|---|---|
author | Michael Anthony Knyszek <mknyszek@google.com> | Thu Feb 18 21:55:26 2021 +0000 |
committer | Michael Knyszek <mknyszek@google.com> | Fri Feb 19 19:06:40 2021 +0000 |
tree | 7989f250fceaa4fddea7d2621f9c6a1abcdc98da | |
parent | 7f0d01687e030f21e8bdc36dfd9d5aac3a6f4a71 [diff] |
design: regenerate graphs for GC pacer redesign A couple of the graphs were wrong (from the wrong scenario, that is) because I copied them in manually. Fatal mistake. Regenerate the graphs following the usual pipeline. Because there's a degree of jitter and randomness in these graphs they end up slightly different, but they're all mostly the same. By regenerating these graphs, it also adds a new line to each graph for the live heap size. I think this is nice for readability, so I'll let that get updated too. For golang/go#44167. Change-Id: I097f812ba07ca7fd740d8460e2830de6492b3945 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/293790 Reviewed-by: Michael Pratt <mpratt@google.com>
diff --git a/design/44167/pacer-plots/new-big-globals.png b/design/44167/pacer-plots/new-big-globals.png index 958f985..7733756 100644 --- a/design/44167/pacer-plots/new-big-globals.png +++ b/design/44167/pacer-plots/new-big-globals.png Binary files differ
diff --git a/design/44167/pacer-plots/new-big-stacks.png b/design/44167/pacer-plots/new-big-stacks.png index 1ab5583..e5c771f 100644 --- a/design/44167/pacer-plots/new-big-stacks.png +++ b/design/44167/pacer-plots/new-big-stacks.png Binary files differ
diff --git a/design/44167/pacer-plots/new-heavy-jitter-alloc.png b/design/44167/pacer-plots/new-heavy-jitter-alloc.png index e5596ec..12aa9ef 100644 --- a/design/44167/pacer-plots/new-heavy-jitter-alloc.png +++ b/design/44167/pacer-plots/new-heavy-jitter-alloc.png Binary files differ
diff --git a/design/44167/pacer-plots/new-heavy-step-alloc.png b/design/44167/pacer-plots/new-heavy-step-alloc.png index d1261ef..3bb6f01 100644 --- a/design/44167/pacer-plots/new-heavy-step-alloc.png +++ b/design/44167/pacer-plots/new-heavy-step-alloc.png Binary files differ
diff --git a/design/44167/pacer-plots/new-high-GOGC.png b/design/44167/pacer-plots/new-high-GOGC.png index 8c9291f..f71df01 100644 --- a/design/44167/pacer-plots/new-high-GOGC.png +++ b/design/44167/pacer-plots/new-high-GOGC.png Binary files differ
diff --git a/design/44167/pacer-plots/new-jitter-alloc.png b/design/44167/pacer-plots/new-jitter-alloc.png index b021d60..8aa5337 100644 --- a/design/44167/pacer-plots/new-jitter-alloc.png +++ b/design/44167/pacer-plots/new-jitter-alloc.png Binary files differ
diff --git a/design/44167/pacer-plots/new-osc-alloc.png b/design/44167/pacer-plots/new-osc-alloc.png index 2d18192..8dada21 100644 --- a/design/44167/pacer-plots/new-osc-alloc.png +++ b/design/44167/pacer-plots/new-osc-alloc.png Binary files differ
diff --git a/design/44167/pacer-plots/new-steady.png b/design/44167/pacer-plots/new-steady.png index 4d4f45c..943acfe 100644 --- a/design/44167/pacer-plots/new-steady.png +++ b/design/44167/pacer-plots/new-steady.png Binary files differ
diff --git a/design/44167/pacer-plots/new-step-alloc.png b/design/44167/pacer-plots/new-step-alloc.png index a8639f3..dd78b60 100644 --- a/design/44167/pacer-plots/new-step-alloc.png +++ b/design/44167/pacer-plots/new-step-alloc.png Binary files differ
diff --git a/design/44167/pacer-plots/old-big-globals.png b/design/44167/pacer-plots/old-big-globals.png index d1e1d13..9377718 100644 --- a/design/44167/pacer-plots/old-big-globals.png +++ b/design/44167/pacer-plots/old-big-globals.png Binary files differ
diff --git a/design/44167/pacer-plots/old-big-stacks.png b/design/44167/pacer-plots/old-big-stacks.png index 80febdf..d1d6802 100644 --- a/design/44167/pacer-plots/old-big-stacks.png +++ b/design/44167/pacer-plots/old-big-stacks.png Binary files differ
diff --git a/design/44167/pacer-plots/old-heavy-jitter-alloc.png b/design/44167/pacer-plots/old-heavy-jitter-alloc.png index 3d5eb1d..e5319c3 100644 --- a/design/44167/pacer-plots/old-heavy-jitter-alloc.png +++ b/design/44167/pacer-plots/old-heavy-jitter-alloc.png Binary files differ
diff --git a/design/44167/pacer-plots/old-heavy-step-alloc.png b/design/44167/pacer-plots/old-heavy-step-alloc.png index 8b297cf..c7ade44 100644 --- a/design/44167/pacer-plots/old-heavy-step-alloc.png +++ b/design/44167/pacer-plots/old-heavy-step-alloc.png Binary files differ
diff --git a/design/44167/pacer-plots/old-high-GOGC.png b/design/44167/pacer-plots/old-high-GOGC.png index 3dbbc20..9cb37de 100644 --- a/design/44167/pacer-plots/old-high-GOGC.png +++ b/design/44167/pacer-plots/old-high-GOGC.png Binary files differ
diff --git a/design/44167/pacer-plots/old-jitter-alloc.png b/design/44167/pacer-plots/old-jitter-alloc.png index ad8d42c..5d7065b 100644 --- a/design/44167/pacer-plots/old-jitter-alloc.png +++ b/design/44167/pacer-plots/old-jitter-alloc.png Binary files differ
diff --git a/design/44167/pacer-plots/old-osc-alloc.png b/design/44167/pacer-plots/old-osc-alloc.png index 7527144..e4dcaea 100644 --- a/design/44167/pacer-plots/old-osc-alloc.png +++ b/design/44167/pacer-plots/old-osc-alloc.png Binary files differ
diff --git a/design/44167/pacer-plots/old-steady.png b/design/44167/pacer-plots/old-steady.png index 7576b9f..c923ef7 100644 --- a/design/44167/pacer-plots/old-steady.png +++ b/design/44167/pacer-plots/old-steady.png Binary files differ
diff --git a/design/44167/pacer-plots/old-step-alloc.png b/design/44167/pacer-plots/old-step-alloc.png index 2b06691..bef8813 100644 --- a/design/44167/pacer-plots/old-step-alloc.png +++ b/design/44167/pacer-plots/old-step-alloc.png Binary files differ