commit 18ef8a7496c375dc3df2b965a7a9475060736c23
author Alexander Rakoczy <alex@golang.org> Tue Jul 09 14:24:17 2019 -0400
committer Alexander Rakoczy <alex@golang.org> Tue Jul 09 18:53:34 2019 +0000
tree f9c1a50b76db419e62e77b8a5cbaba59dd8dbcd4
parent 607f1dfb1a2b976115af86da310d39a630f7d887

playground: push image in trigger before deploying

Removes post-build trigger step of pushing image, and adds a push step
step before AppEngine deployment. This ensures that the image we just
built is pushed before asking AppEngine to deploy it.

This is documented at:
https://cloud.google.com/cloud-build/docs/configuring-builds/build-test-deploy-artifacts

Cloud Build is authorized to push images to gcr.io. This change was
tested by submitting a build with this configuration without the
deployment step.

Updates golang/go#32606

Change-Id: I4e7cc242566378e4ca6d52244fb81bf410e79314
Reviewed-on: https://go-review.googlesource.com/c/playground/+/185339
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

cloudbuild_trigger.json

diff --git a/cloudbuild_trigger.json b/cloudbuild_trigger.json
index d37d803..620d320 100644
--- a/cloudbuild_trigger.json
+++ b/cloudbuild_trigger.json
@@ -45,6 +45,13 @@
         ]
       },
       {
+        "name": "gcr.io/cloud-builders/docker",
+        "args": [
+          "push",
+          "gcr.io/$PROJECT_ID/playground"
+        ]
+      },
+      {
         "dir": "playground",
         "name": "gcr.io/cloud-builders/gcloud",
         "args": [
@@ -56,9 +63,6 @@
         ]
       }
     ],
-    "timeout": "1800s",
-    "images": [
-      "gcr.io/$PROJECT_ID/playground"
-    ]
+    "timeout": "1800s"
   }
 }