internal/middleware,worker: fix staticcheck errors
Remove unused code to fix:
internal/middleware/quota_test.go:18:6: func collectViewData is unused (U1000)
internal/middleware/quota_test.go:53:6: func boolptr is unused (U1000)
internal/worker/fetch_test.go:60:8: const goRepositoryURLPrefix is unused (U1000)
Change-Id: I8ad88c8c59e495ce051eeb7fc52de67339a6cf95
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/278535
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
diff --git a/internal/middleware/quota_test.go b/internal/middleware/quota_test.go
index e910544..c31a96e 100644
--- a/internal/middleware/quota_test.go
+++ b/internal/middleware/quota_test.go
@@ -12,26 +12,8 @@
"github.com/alicebob/miniredis/v2"
"github.com/go-redis/redis/v8"
- "go.opencensus.io/stats/view"
)
-func collectViewData(t *testing.T) map[bool]int {
- m := map[bool]int{}
- rows, err := view.RetrieveData(QuotaResultCount.Name)
- if err != nil {
- t.Fatal(err)
- }
- for _, row := range rows {
- blocked := row.Tags[0].Value == "blocked"
- if err != nil {
- t.Fatalf("collectViewData: %v", err)
- }
- count := int(row.Data.(*view.CountData).Value)
- m[blocked] = count
- }
- return m
-}
-
func TestIPKey(t *testing.T) {
for _, test := range []struct {
in string
@@ -50,8 +32,6 @@
}
}
-func boolptr(b bool) *bool { return &b }
-
func TestEnforceQuota(t *testing.T) {
// This test is inherently time-dependent, so inherently flaky, especially on CI.
// So run it a few times before giving up.
diff --git a/internal/worker/fetch_test.go b/internal/worker/fetch_test.go
index 25fcf74..e311a8a 100644
--- a/internal/worker/fetch_test.go
+++ b/internal/worker/fetch_test.go
@@ -57,8 +57,6 @@
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
defer cancel()
- const goRepositoryURLPrefix = "https://github.com/golang"
-
stdlib.UseTestData = true
defer func() { stdlib.UseTestData = false }()
