| commit | c069bf17f5128d06e43edfb2ee046f291d6e20e4 | [log] [tgz] |
|---|---|---|
| author | Jonathan Amsterdam <jba@google.com> | Wed Dec 09 10:09:46 2020 -0500 |
| committer | Jonathan Amsterdam <jba@google.com> | Mon Dec 14 21:33:15 2020 +0000 |
| tree | 8b49320ad4ffad7747d5f884e87c01e2f3b38451 | |
| parent | 10f755d2f8aee362741cbd53efae9af1a62fb89c [diff] |
internal/godoc/dochtml/internal/render: fix long-literal comment rendering The presence of a long literal caused all struct fields comments to be removed. This imperfectly fixes the problem by collecting all comments when walking the declaration AST. Previously, it was thought that the comments in an ast.CommentedNode would augment the existing comments instead of replacing them (see golang/go#39219). The fix, as in https://golang.org/cl/240217 and copied here, is to collect all comments during the walk. This isn't sufficient, because using a CommentedNode also turns off the "contains filtered or unexported" comments that are normally added during printing. So we have to add them back manually, which is tricky, and can't be done perfectly (there are extra blank lines). For golang/go#42425 Change-Id: I0bd8e5ddfc764bc3c7610575e1e3eedf9c0bfd84 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/276632 Trust: Jonathan Amsterdam <jba@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> Reviewed-by: Julie Qiu <julie@golang.org>
Pkg.go.dev is a website for discovering and evaluating Go packages and modules.
You can check it out at https://pkg.go.dev.
Pkg.go.dev launched in November 2019, and is currently under active development by the Go team.
Here's what we are currently working on:
Design updates: We have some design changes planned for pkg.go.dev, to address UX feedback that we have received. You can expect a more cohesive search and navigation experience coming soon. We plan to share these designs for feedback once they are ready.
Godoc.org redirect: Longer term, we are working towards redirecting godoc.org traffic to pkg.go.dev. We know that there are features available on godoc.org that users want to see on pkg.go.dev, and we want to ensure that we address these. We’ve been keeping track of issues related to redirecting godoc.org traffic on Go issue #39144. These issues will be prioritized in the next few months. We also plan to continue improving our license detection algorithm.
Search improvements: We’ll be improving our search experience based on feedback in Go issue #37810, to make it easier for users to find the dependencies they are looking for and make better decisions around which ones to import.
We encourage everyone to begin using pkg.go.dev today for all of their needs and to file feedback! You can redirect all of your requests from godoc.org to pkg.go.dev, by clicking Always use pkg.go.dev at the top of any page on godoc.org.
If you want to report a bug or have a feature suggestion, please first check the known issues to see if your issue is already being discussed. If an issue does not already exist, feel free to file an issue.
For answers to frequently asked questions, see go.dev/about.
You can also chat with us on the #tools slack channel on the Gophers slack.
We would love your help!
Our canonical Git repository is located at go.googlesource.com/pkgsite. There is a mirror of the repository at github.com/golang/pkgsite.
To contribute, please read our contributing guide.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.