commit 9d6948add2d169eb97c49ca95bdd976e3fee91f1
author Julie Qiu <julie@golang.org> Mon Oct 05 15:41:12 2020 -0400
committer Julie Qiu <julie@golang.org> Tue Oct 06 01:23:14 2020 +0000
tree 347b1bce382276e61941b9fe2fa10fcc4cdc32b6
parent cd0bd5e540ccc2291020c804059aef96a2553d15

internal/frontend: use link version for breadcrumbs

Rather than computing the linkVersion in displayBreadcrumbs, compute
this value in breadcrumbs, where it is used.

Change-Id: Id8bcfd33a09180aecabbace1bb5a5502fef8f5c1
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/259620
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>

internal/frontend/header.go

diff --git a/internal/frontend/header.go b/internal/frontend/header.go
index bf5d7c2..cdf3c14 100644
--- a/internal/frontend/header.go
+++ b/internal/frontend/header.go
@@ -189,7 +189,7 @@
 	for i := 1; i < len(dirs); i++ {
 		href := "/" + dirs[i]
 		if requestedVersion != internal.LatestVersion {
-			href += "@" + requestedVersion
+			href += "@" + linkVersion(requestedVersion, modPath)
 		}
 		el := dirs[i]
 		if i != len(dirs)-1 {

internal/frontend/unit.go

diff --git a/internal/frontend/unit.go b/internal/frontend/unit.go
index 432a00d..67161d3 100644
--- a/internal/frontend/unit.go
+++ b/internal/frontend/unit.go
@@ -328,13 +328,7 @@
 // displayBreadcrumbs appends additional breadcrumb links for display
 // to those for the given unit.
 func displayBreadcrumb(unit *internal.Unit, requestedVersion string) breadcrumb {
-	v := requestedVersion
-	if unit.ModulePath == stdlib.ModulePath {
-		// TODO: Fix definition of requestedVersion, so that the
-		// requestedVersion is the goTag, not the resolved semantic version.
-		v = goTagForVersion(requestedVersion)
-	}
-	bc := breadcrumbPath(unit.Path, unit.ModulePath, v)
+	bc := breadcrumbPath(unit.Path, unit.ModulePath, requestedVersion)
 	if unit.ModulePath == stdlib.ModulePath && unit.Path != stdlib.ModulePath {
 		bc.Links = append([]link{{Href: "/std", Body: "Standard library"}}, bc.Links...)
 	}