internal: remove experiment insert-symbol-search-documents
This experiment is live in all environments and can be removed.
For golang/go#44142
Change-Id: Ie653e833b8fc04d5a538fab41137ca77a0989125
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/341451
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
diff --git a/internal/experiment.go b/internal/experiment.go
index b363409..8a221e7 100644
--- a/internal/experiment.go
+++ b/internal/experiment.go
@@ -6,33 +6,31 @@
package internal
const (
- ExperimentDeprecatedDoc = "deprecated-doc"
- ExperimentEnableStdFrontendFetch = "enable-std-frontend-fetch"
- ExperimentInsertSymbolSearchDocuments = "insert-symbol-search-documents"
- ExperimentNewUnitLayout = "new-unit-layout"
- ExperimentSearchGrouping = "search-grouping"
- ExperimentSearchIncrementally = "search-incrementally"
- ExperimentSkipInsertSymbols = "skip-insert-symbols"
- ExperimentStyleGuide = "styleguide"
- ExperimentSymbolHistoryMainPage = "symbol-history-main-page"
- ExperimentSymbolHistoryVersionsPage = "symbol-history-versions-page"
- ExperimentSymbolSearch = "symbol-search"
+ ExperimentDeprecatedDoc = "deprecated-doc"
+ ExperimentEnableStdFrontendFetch = "enable-std-frontend-fetch"
+ ExperimentNewUnitLayout = "new-unit-layout"
+ ExperimentSearchGrouping = "search-grouping"
+ ExperimentSearchIncrementally = "search-incrementally"
+ ExperimentSkipInsertSymbols = "skip-insert-symbols"
+ ExperimentStyleGuide = "styleguide"
+ ExperimentSymbolHistoryMainPage = "symbol-history-main-page"
+ ExperimentSymbolHistoryVersionsPage = "symbol-history-versions-page"
+ ExperimentSymbolSearch = "symbol-search"
)
// Experiments represents all of the active experiments in the codebase and
// a description of each experiment.
var Experiments = map[string]string{
- ExperimentDeprecatedDoc: "Treat deprecated symbols specially in documentation.",
- ExperimentEnableStdFrontendFetch: "Enable frontend fetching for module std.",
- ExperimentInsertSymbolSearchDocuments: "Insert data into symbol_search_documents and documentation_symbols.",
- ExperimentNewUnitLayout: "Enable the new layout on the unit page.",
- ExperimentSearchGrouping: "Group search results.",
- ExperimentSearchIncrementally: "Use incremental query for search results.",
- ExperimentSkipInsertSymbols: "Don't insert data into symbols tables.",
- ExperimentStyleGuide: "Enable the styleguide.",
- ExperimentSymbolHistoryMainPage: "Show package API history on the main unit page.",
- ExperimentSymbolHistoryVersionsPage: "Show package API history on the versions page.",
- ExperimentSymbolSearch: "Enable searching for symbols.",
+ ExperimentDeprecatedDoc: "Treat deprecated symbols specially in documentation.",
+ ExperimentEnableStdFrontendFetch: "Enable frontend fetching for module std.",
+ ExperimentNewUnitLayout: "Enable the new layout on the unit page.",
+ ExperimentSearchGrouping: "Group search results.",
+ ExperimentSearchIncrementally: "Use incremental query for search results.",
+ ExperimentSkipInsertSymbols: "Don't insert data into symbols tables.",
+ ExperimentStyleGuide: "Enable the styleguide.",
+ ExperimentSymbolHistoryMainPage: "Show package API history on the main unit page.",
+ ExperimentSymbolHistoryVersionsPage: "Show package API history on the versions page.",
+ ExperimentSymbolSearch: "Enable searching for symbols.",
}
// Experiment holds data associated with an experimental feature for frontend
diff --git a/internal/postgres/symbol.go b/internal/postgres/symbol.go
index 9bd1459..b40919f 100644
--- a/internal/postgres/symbol.go
+++ b/internal/postgres/symbol.go
@@ -14,7 +14,6 @@
"golang.org/x/pkgsite/internal"
"golang.org/x/pkgsite/internal/database"
"golang.org/x/pkgsite/internal/derrors"
- "golang.org/x/pkgsite/internal/experiment"
"golang.org/x/pkgsite/internal/version"
)
@@ -79,10 +78,6 @@
pathToDocIDToDoc map[string]map[int]*internal.Documentation) (err error) {
defer derrors.WrapStack(&err, "upsertDocumentationSymbols(ctx, db, pathToPkgsymID, pathToDocIDToDoc)")
- if !experiment.IsActive(ctx, internal.ExperimentInsertSymbolSearchDocuments) {
- return nil
- }
-
// Create a map of documentation_id TO package_symbol_id set.
// This will be used to verify that all package_symbols for the unit have
// been inserted.
diff --git a/internal/postgres/symbol_test.go b/internal/postgres/symbol_test.go
index 845da02..5d9431d 100644
--- a/internal/postgres/symbol_test.go
+++ b/internal/postgres/symbol_test.go
@@ -16,7 +16,6 @@
"golang.org/x/pkgsite/internal"
"golang.org/x/pkgsite/internal/database"
"golang.org/x/pkgsite/internal/derrors"
- "golang.org/x/pkgsite/internal/experiment"
"golang.org/x/pkgsite/internal/testing/sample"
)
@@ -25,9 +24,6 @@
testDB, release := acquire(t)
defer release()
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
- ctx = experiment.NewContext(ctx,
- internal.ExperimentInsertSymbolSearchDocuments,
- )
defer cancel()
mod := sample.DefaultModule()
@@ -91,9 +87,6 @@
testDB, release := acquire(t)
defer release()
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
- ctx = experiment.NewContext(ctx,
- internal.ExperimentInsertSymbolSearchDocuments,
- )
defer cancel()
mod := sample.DefaultModule()
@@ -122,9 +115,6 @@
testDB, release := acquire(t)
defer release()
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
- ctx = experiment.NewContext(ctx,
- internal.ExperimentInsertSymbolSearchDocuments,
- )
defer cancel()
typ := internal.Symbol{
@@ -225,9 +215,6 @@
testDB, release := acquire(t)
defer release()
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
- ctx = experiment.NewContext(ctx,
- internal.ExperimentInsertSymbolSearchDocuments,
- )
defer cancel()
typ := internal.Symbol{
diff --git a/internal/postgres/symbolsearch.go b/internal/postgres/symbolsearch.go
index fd7053e..d86ae3f 100644
--- a/internal/postgres/symbolsearch.go
+++ b/internal/postgres/symbolsearch.go
@@ -13,10 +13,8 @@
"strings"
"github.com/lib/pq"
- "golang.org/x/pkgsite/internal"
"golang.org/x/pkgsite/internal/database"
"golang.org/x/pkgsite/internal/derrors"
- "golang.org/x/pkgsite/internal/experiment"
"golang.org/x/pkgsite/internal/postgres/symbolsearch"
"golang.org/x/sync/errgroup"
)
@@ -25,10 +23,6 @@
modulePath, v string) (err error) {
defer derrors.Wrap(&err, "upsertSymbolSearchDocuments(ctx, ddb, %q, %q)", modulePath, v)
- if !experiment.IsActive(ctx, internal.ExperimentInsertSymbolSearchDocuments) {
- return nil
- }
-
// If a user is looking for the symbol "DB.Begin", from package
// database/sql, we want them to be able to find this by searching for
// "DB.Begin" and "sql.DB.Begin". Searching for "sql.DB", "DB", "Begin" or
diff --git a/internal/postgres/symbolsearch_test.go b/internal/postgres/symbolsearch_test.go
index e5c4424..7777a2a 100644
--- a/internal/postgres/symbolsearch_test.go
+++ b/internal/postgres/symbolsearch_test.go
@@ -11,13 +11,11 @@
"github.com/google/go-cmp/cmp"
"golang.org/x/pkgsite/internal"
- "golang.org/x/pkgsite/internal/experiment"
"golang.org/x/pkgsite/internal/testing/sample"
)
func TestSymbolSearch(t *testing.T) {
ctx := context.Background()
- ctx = experiment.NewContext(ctx, internal.ExperimentInsertSymbolSearchDocuments)
testDB, release := acquire(t)
defer release()
@@ -122,7 +120,6 @@
// (SQLSTATE 21000)
func TestUpsertSymbolSearch_UniqueConstraints(t *testing.T) {
ctx := context.Background()
- ctx = experiment.NewContext(ctx, internal.ExperimentInsertSymbolSearchDocuments)
testDB, release := acquire(t)
defer release()
diff --git a/tests/e2e/grouped-search/config.yaml b/tests/e2e/grouped-search/config.yaml
index 4f2cf88..8dfdef5 100644
--- a/tests/e2e/grouped-search/config.yaml
+++ b/tests/e2e/grouped-search/config.yaml
@@ -1,6 +1,4 @@
experiments:
- - name: insert-symbol-search-documents
- rollout: 100
- name: search-grouping
rollout: 100
- name: symbol-search
diff --git a/tests/search/config.yaml b/tests/search/config.yaml
index 3dc874d..dc9c6ba 100644
--- a/tests/search/config.yaml
+++ b/tests/search/config.yaml
@@ -1,6 +1,4 @@
experiments:
-- Name: insert-symbol-search-documents
- Rollout: 100
- Name: search-grouping
Rollout: 100
- Name: symbol-search
diff --git a/tests/search/main.go b/tests/search/main.go
index fb48d55..f579afe 100755
--- a/tests/search/main.go
+++ b/tests/search/main.go
@@ -55,7 +55,6 @@
)
var symbolSearchExperiments = []string{
- internal.ExperimentInsertSymbolSearchDocuments,
internal.ExperimentSearchGrouping,
internal.ExperimentSymbolSearch,
}
