commit 57b5ee4d83f670469379d909777ca77f40702ce8
author Julie Qiu <julie@golang.org> Mon Apr 27 11:21:37 2020 -0400
committer Julie Qiu <julieqiu@google.com> Wed Apr 29 15:35:19 2020 +0000
tree c345dc9a1e9e463c722b4bcd03eb82df0135572a
parent 4dd7cccfabb454a59d8636171f391fcea007e43c

internal/postgres: use InsertModule instead of saveModule in postgres tests

saveModule is an unexported function and implementation detail of
internal/postgres. InsertModule is used instead for tests.

Change-Id: I0dd6bfe68cd0644ba449d7ea101c7228b505cfdf
Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/729483
Reviewed-by: Jonathan Amsterdam <jba@google.com>

internal/postgres/details_test.go

diff --git a/internal/postgres/details_test.go b/internal/postgres/details_test.go
index b75ee92..00b08fc 100644
--- a/internal/postgres/details_test.go
+++ b/internal/postgres/details_test.go
@@ -44,21 +44,21 @@
 	}{
 		{
 			name: "largest release",
-			path: "mod1",
+			path: "mod.1",
 			modules: []*internal.Module{
-				sampleModule("mod1", "v1.1.0-alpha.1", version.TypePrerelease),
-				sampleModule("mod1", "v1.0.0", version.TypeRelease),
-				sampleModule("mod1", "v1.0.0-20190311183353-d8887717615a", version.TypePseudo),
+				sampleModule("mod.1", "v1.1.0-alpha.1", version.TypePrerelease),
+				sampleModule("mod.1", "v1.0.0", version.TypeRelease),
+				sampleModule("mod.1", "v1.0.0-20190311183353-d8887717615a", version.TypePseudo),
 			},
 			wantIndex: 1,
 		},
 		{
 			name: "largest prerelease",
-			path: "mod2",
+			path: "mod.2",
 			modules: []*internal.Module{
-				sampleModule("mod2", "v1.1.0-beta.10", version.TypePrerelease),
-				sampleModule("mod2", "v1.1.0-beta.2", version.TypePrerelease),
-				sampleModule("mod2", "v1.0.0-20190311183353-d8887717615a", version.TypePseudo),
+				sampleModule("mod.2", "v1.1.0-beta.10", version.TypePrerelease),
+				sampleModule("mod.2", "v1.1.0-beta.2", version.TypePrerelease),
+				sampleModule("mod.2", "v1.0.0-20190311183353-d8887717615a", version.TypePseudo),
 			},
 			wantIndex: 0,
 		},
@@ -72,7 +72,7 @@
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
 			for _, v := range tc.modules {
-				if err := saveModule(ctx, testDB.db, v); err != nil {
+				if err := testDB.InsertModule(ctx, v); err != nil {
 					t.Error(err)
 				}
 			}
@@ -172,7 +172,7 @@
 			defer cancel()
 
 			for _, v := range testModules {
-				if err := saveModule(ctx, testDB.db, v); err != nil {
+				if err := testDB.InsertModule(ctx, v); err != nil {
 					t.Error(err)
 				}
 			}
@@ -283,7 +283,7 @@
 				// TODO: move this handling into SimpleVersion once ParseVersionType is
 				// factored out of fetch.go
 				m.VersionType = version.TypePseudo
-				if err := saveModule(ctx, testDB.db, m); err != nil {
+				if err := testDB.InsertModule(ctx, m); err != nil {
 					t.Fatal(err)
 				}
 
@@ -299,7 +299,7 @@
 			}
 
 			for _, m := range tc.modules {
-				if err := saveModule(ctx, testDB.db, m); err != nil {
+				if err := testDB.InsertModule(ctx, m); err != nil {
 					t.Fatal(err)
 				}
 			}
@@ -360,7 +360,7 @@
 			ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
 			defer cancel()
 
-			if err := saveModule(ctx, testDB.db, tc.module); err != nil {
+			if err := testDB.InsertModule(ctx, tc.module); err != nil {
 				t.Error(err)
 			}
 
@@ -409,7 +409,7 @@
 	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
 	defer cancel()
 
-	if err := saveModule(ctx, testDB.db, testModule); err != nil {
+	if err := testDB.InsertModule(ctx, testModule); err != nil {
 		t.Fatal(err)
 	}