commit 1b07102323f9e84c2b367d4d0e7fa91581b80ff3
author Jonathan Amsterdam <jba@google.com> Tue Sep 07 08:39:48 2021 -0400
committer Jonathan Amsterdam <jba@google.com> Tue Sep 07 15:12:40 2021 +0000
tree 79dec9640d77bf78fca83d76a9d4e2bde0292311
parent acf19d27abc759d37970cb3d9474fafef4f48fb4

internal/frontend/versions.go: minor cleanup

Move some field assignments into struct literals.

For golang/go#48223

Change-Id: I18e87e709577592020ad9b7e2c17b40c7275811b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/347970
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>

internal/frontend/versions.go

diff --git a/internal/frontend/versions.go b/internal/frontend/versions.go
index bd11c07..a784731 100644
--- a/internal/frontend/versions.go
+++ b/internal/frontend/versions.go
@@ -173,20 +173,20 @@
 			major = "v1"
 		}
 		key := VersionListKey{
-			ModulePath:   mi.ModulePath,
-			Major:        major,
-			Incompatible: version.IsIncompatible(mi.Version),
+			ModulePath:         mi.ModulePath,
+			Major:              major,
+			Incompatible:       version.IsIncompatible(mi.Version),
+			Deprecated:         mi.Deprecated,
+			DeprecationComment: shortRationale(mi.DeprecationComment),
 		}
 		vs := &VersionSummary{
-			Link:       linkify(mi),
-			CommitTime: absoluteTime(mi.CommitTime),
-			Version:    linkVersion(mi.ModulePath, mi.Version, mi.Version),
-			IsMinor:    isMinor(mi.Version),
+			Link:                linkify(mi),
+			CommitTime:          absoluteTime(mi.CommitTime),
+			Version:             linkVersion(mi.ModulePath, mi.Version, mi.Version),
+			IsMinor:             isMinor(mi.Version),
+			Retracted:           mi.Retracted,
+			RetractionRationale: shortRationale(mi.RetractionRationale),
 		}
-		key.Deprecated = mi.Deprecated
-		key.DeprecationComment = shortRationale(mi.DeprecationComment)
-		vs.Retracted = mi.Retracted
-		vs.RetractionRationale = shortRationale(mi.RetractionRationale)
 		if sv := sh.SymbolsAtVersion(mi.Version); sv != nil {
 			vs.Symbols = symbolsForVersion(linkify(mi), sv)
 		}