internal/gerrit: lint (staticcheck)

Change-Id: Ic166e43c8cda7bd9fc129a8948c0d37d31f284da
Reviewed-on: https://go-review.googlesource.com/c/oscar/+/750242
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: David Chase <drchase@google.com>

internal/gerrit/sync.go

diff --git a/internal/gerrit/sync.go b/internal/gerrit/sync.go
index b5e6221..8acc6f4 100644
--- a/internal/gerrit/sync.go
+++ b/internal/gerrit/sync.go
@@ -424,8 +424,6 @@
 			return some, nil
 		}
 	}
-
-	return some, nil
 }
 
 // syncComments updates the comments of a change in the database.

internal/gerrit/sync_test.go

diff --git a/internal/gerrit/sync_test.go b/internal/gerrit/sync_test.go
index 1223725..688913e 100644
--- a/internal/gerrit/sync_test.go
+++ b/internal/gerrit/sync_test.go
@@ -418,7 +418,7 @@
 	project := "test"
 	numCLs := func(c *Client) int {
 		cnt := 0
-		for _, _ = range c.ChangeNumbers(project) {
+		for range c.ChangeNumbers(project) {
 			cnt++
 		}
 		return cnt

internal/gerrit/testing.go

diff --git a/internal/gerrit/testing.go b/internal/gerrit/testing.go
index b247e51..28c5a3d 100644
--- a/internal/gerrit/testing.go
+++ b/internal/gerrit/testing.go
@@ -259,7 +259,6 @@
 			return "", err
 		}
 		data = rest
-		break
 
 	case reflect.Slice:
 		switch field.Type().Elem().Kind() {

internal/gerrit/types.go

diff --git a/internal/gerrit/types.go b/internal/gerrit/types.go
index 8f3952b..3d8c298 100644
--- a/internal/gerrit/types.go
+++ b/internal/gerrit/types.go
@@ -260,7 +260,7 @@
 	// CLOSED, closed changes cannot be submitted.
 	// FORCED, the change was submitted bypassing the submit rule.
 	// RULE_ERROR, rule code failed with an error.
-	status string `json:"status"`
+	Status string `json:"status"`
 	// A list of labels, each containing the following fields.
 	// * label: the label name.
 	// * status: