http2: add error counter to one missing processHeaders error path And unrelated typo fix. Updates golang/go#48675 Change-Id: Id90e0e76e514ba550fa2d3c9e1104ebfd4c23a9b Reviewed-on: https://go-review.googlesource.com/c/net/+/353031 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org> Trust: Josh Bleecher Snyder <josharian@gmail.com>
diff --git a/http2/server.go b/http2/server.go index 1caab32..c67e9b7 100644 --- a/http2/server.go +++ b/http2/server.go
@@ -2009,7 +2009,7 @@ isConnect := rp.method == "CONNECT" if isConnect { if rp.path != "" || rp.scheme != "" || rp.authority == "" { - return nil, nil, streamError(f.StreamID, ErrCodeProtocol) + return nil, nil, sc.countError("bad_connect", streamError(f.StreamID, ErrCodeProtocol)) } } else if rp.method == "" || rp.path == "" || (rp.scheme != "https" && rp.scheme != "http") { // See 8.1.2.6 Malformed Requests and Responses:
diff --git a/http2/transport.go b/http2/transport.go index 94e0bef..a45e2e1 100644 --- a/http2/transport.go +++ b/http2/transport.go
@@ -2612,7 +2612,7 @@ cc := rl.cc cs := cc.streamByID(f.StreamID, true) if cs == nil { - // TODO: return error if server tries to RST_STEAM an idle stream + // TODO: return error if server tries to RST_STREAM an idle stream return nil } if cc.isDoNotReuseAndIdle() {