commit c95aed5357e77a4bf7d3955c46740000a17adee1
author Mickael KERJEAN <mickael.kerjean@gmail.com> Wed Feb 27 15:51:09 2019 +0000
committer Brad Fitzpatrick <bradfitz@golang.org> Wed Feb 27 16:05:52 2019 +0000
tree 4322f9d3b17381f9e0e1fc6d3c1d24761bb59e89
parent e86916475b29d8072b8616ce1438a40bdab4ca39

webdav: add trailing slash on directories

Fixes golang/go#29858

Change-Id: I7bd8357a7def7daab1fd6357a888ff4e676a1bee
GitHub-Last-Rev: a6dc776fa3aad595643943dcff88efcf152d6be1
GitHub-Pull-Request: golang/net#32
Reviewed-on: https://go-review.googlesource.com/c/163863
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

webdav/webdav.go

diff --git a/webdav/webdav.go b/webdav/webdav.go
index 744d2d5..b04c5dd 100644
--- a/webdav/webdav.go
+++ b/webdav/webdav.go
@@ -556,7 +556,11 @@
 		if err != nil {
 			return err
 		}
-		return mw.write(makePropstatResponse(path.Join(h.Prefix, reqPath), pstats))
+		href := path.Join(h.Prefix, reqPath)
+		if info.IsDir() {
+			href += "/"
+		}
+		return mw.write(makePropstatResponse(href, pstats))
 	}
 
 	walkErr := walkFS(ctx, h.FileSystem, depth, reqPath, fi, walkFn)

webdav/webdav_test.go

diff --git a/webdav/webdav_test.go b/webdav/webdav_test.go
index 46d1bb6..4daa031 100644
--- a/webdav/webdav_test.go
+++ b/webdav/webdav_test.go
@@ -284,7 +284,7 @@
 		wantDisplayName: `こんにちわ世界`,
 	}, {
 		name:            `/Program Files/`,
-		wantHref:        `/Program%20Files`,
+		wantHref:        `/Program%20Files/`,
 		wantDisplayName: `Program Files`,
 	}, {
 		name:            `/go+lang`,