html: don't adjust xml:base Change-Id: Ifac8571bedbb153b7e97ce2d2af47b5bc05b381c Reviewed-on: https://go-review.googlesource.com/c/net/+/781893 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Roland Shoemaker <roland@golang.org> Reviewed-by: Nicholas Husin <nsh@golang.org> Reviewed-by: Nicholas Husin <husin@google.com>
diff --git a/html/foreign.go b/html/foreign.go index e8515d8..65d01d1 100644 --- a/html/foreign.go +++ b/html/foreign.go
@@ -23,7 +23,7 @@ } switch a.Key { case "xlink:actuate", "xlink:arcrole", "xlink:href", "xlink:role", "xlink:show", - "xlink:title", "xlink:type", "xml:base", "xml:lang", "xml:space", "xmlns:xlink": + "xlink:title", "xlink:type", "xml:lang", "xml:space", "xmlns:xlink": j := strings.Index(a.Key, ":") aa[i].Namespace = a.Key[:j] aa[i].Key = a.Key[j+1:]
diff --git a/html/parse_test.go b/html/parse_test.go index 4dad767..8f2b49b 100644 --- a/html/parse_test.go +++ b/html/parse_test.go
@@ -152,9 +152,6 @@ } func (a sortedAttributes) Less(i, j int) bool { - if a[i].Namespace != a[j].Namespace { - return a[i].Namespace < a[j].Namespace - } return a[i].Key < a[j].Key } @@ -245,10 +242,6 @@ var testDataDirs = []string{"testdata/html5lib-tests/tree-construction/", "testdata/go/"} func TestParser(t *testing.T) { - skipTests := map[string]bool{ - "testdata/html5lib-tests/tree-construction/webkit02.dat/22": true, // xml attribute sort & replace - } - for _, testDataDir := range testDataDirs { testFiles, err := filepath.Glob(testDataDir + "*.dat") if err != nil { @@ -276,10 +269,6 @@ testId := fmt.Sprintf("%s/%d", strings.ReplaceAll(tf, string(os.PathSeparator), "/"), i) t.Run(testId, func(t *testing.T) { - if skipTests[testId] { - t.Skip("Skipping known broken test") - } - err = testParseCase(ta.text, ta.want, ta.context, ParseOptionEnableScripting(ta.scripting)) if err != nil { t.Errorf("%s test #%d %q, %s", tf, i, ta.text, err)