commit | 4f30a5c0130f199e0dfd54e9de49f9367cabf1ad | [log] [tgz] |
---|---|---|
author | Damien Neil <dneil@google.com> | Fri Oct 15 12:43:53 2021 -0700 |
committer | Damien Neil <dneil@google.com> | Fri Oct 15 21:04:44 2021 +0000 |
tree | f81ecdd3684efeeaeba2ed43d8c8a4e0a5aeebfe | |
parent | db2dff38ab417da63400eed644b5c77ddcd07e22 [diff] |
http2: deflake TestTransportRetriesOnStreamProtocolError During this test: -> client sends req1 <- server sends req1 headers -> client sends req2 <- server resets req2 <- server sends END_STREAM for req1 -> client closes the *server* connection The flake occurs when the last two steps happen out of order: The client processes the reset for req2, returns from RoundTrip, and the test closes the connection before the server writes the last DATA frame for req1. This can be demonstrated by inserting a 1ms sleep between WriteRSTStream and WriteData on the server side of the test. It isn't clear why the client side of the test is closing the server side of the connection; it isn't essential to the test in any way. Remove it. Fixes golang/go#48994. Change-Id: If074e45a76205ebd245617ef1b068967a6674b94 Reviewed-on: https://go-review.googlesource.com/c/net/+/356329 Trust: Damien Neil <dneil@google.com> Run-TryBot: Damien Neil <dneil@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.