all: fix go vet warnings
http2/h2c/h2c_test.go:27:19: golang.org/x/net/http2.Setting composite literal uses unkeyed fields
webdav/prop_test.go:152:5: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:153:5: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:191:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:202:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:217:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:227:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:241:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:251:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:496:23: encoding/xml.Name composite literal uses unkeyed fields
http2/transport_test.go:5310:5: call to (*T).Fatal from a non-test goroutine
http2/transport_test.go:5317:5: call to (*T).Fatal from a non-test goroutine
http2/transport_test.go:5660:3: unreachable code
Change-Id: I8dc72b976d05dc96ae18d73660c83fc9a5584ce1
GitHub-Last-Rev: a19dceaf92b79bb87237a52e828b858eab5034d1
GitHub-Pull-Request: golang/net#133
Reviewed-on: https://go-review.googlesource.com/c/net/+/406454
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Dan Kortschak <dan@kortschak.io>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dan Kortschak <dan@kortschak.io>
TryBot-Result: Gopher Robot <gobot@golang.org>
diff --git a/http2/h2c/h2c_test.go b/http2/h2c/h2c_test.go
index bd9461e..d315632 100644
--- a/http2/h2c/h2c_test.go
+++ b/http2/h2c/h2c_test.go
@@ -24,7 +24,7 @@
var buf bytes.Buffer
swallower := newSettingsAckSwallowWriter(bufio.NewWriter(&buf))
fw := http2.NewFramer(swallower, nil)
- fw.WriteSettings(http2.Setting{http2.SettingMaxFrameSize, 2})
+ fw.WriteSettings(http2.Setting{ID: http2.SettingMaxFrameSize, Val: 2})
fw.WriteSettingsAck()
fw.WriteData(1, true, []byte{})
swallower.Flush()
diff --git a/http2/transport_test.go b/http2/transport_test.go
index c027255..bf6683b 100644
--- a/http2/transport_test.go
+++ b/http2/transport_test.go
@@ -5307,14 +5307,16 @@
defer wg.Done()
req, err := http.NewRequest("POST", st.ts.URL, strings.NewReader(filler))
if err != nil {
- t.Fatal(err)
+ t.Error(err)
+ return
}
req.Header.Set("Big", filler)
req.Trailer = make(http.Header)
req.Trailer.Set("Big", filler)
res, err := tr.RoundTrip(req)
if err != nil {
- t.Fatal(err)
+ t.Error(err)
+ return
}
if got, want := res.StatusCode, 200; got != want {
t.Errorf("StatusCode = %v; want %v", got, want)
@@ -5657,7 +5659,6 @@
}
}
}
- return nil
}
ct.run()
}
diff --git a/webdav/prop_test.go b/webdav/prop_test.go
index 855446b..f4247e6 100644
--- a/webdav/prop_test.go
+++ b/webdav/prop_test.go
@@ -149,8 +149,8 @@
op: "allprop",
name: "/file",
pnames: []xml.Name{
- {"DAV:", "resourcetype"},
- {"foo", "bar"},
+ {Space: "DAV:", Local: "resourcetype"},
+ {Space: "foo", Local: "bar"},
},
wantPropstats: []Propstat{{
Status: http.StatusOK,
@@ -188,7 +188,7 @@
propOp: []propOp{{
op: "propfind",
name: "/dir",
- pnames: []xml.Name{{"DAV:", "resourcetype"}},
+ pnames: []xml.Name{{Space: "DAV:", Local: "resourcetype"}},
wantPropstats: []Propstat{{
Status: http.StatusOK,
Props: []Property{{
@@ -199,7 +199,7 @@
}, {
op: "propfind",
name: "/file",
- pnames: []xml.Name{{"DAV:", "resourcetype"}},
+ pnames: []xml.Name{{Space: "DAV:", Local: "resourcetype"}},
wantPropstats: []Propstat{{
Status: http.StatusOK,
Props: []Property{{
@@ -214,7 +214,7 @@
propOp: []propOp{{
op: "propfind",
name: "/dir",
- pnames: []xml.Name{{"DAV:", "getcontentlanguage"}},
+ pnames: []xml.Name{{Space: "DAV:", Local: "getcontentlanguage"}},
wantPropstats: []Propstat{{
Status: http.StatusNotFound,
Props: []Property{{
@@ -224,7 +224,7 @@
}, {
op: "propfind",
name: "/dir",
- pnames: []xml.Name{{"DAV:", "creationdate"}},
+ pnames: []xml.Name{{Space: "DAV:", Local: "creationdate"}},
wantPropstats: []Propstat{{
Status: http.StatusNotFound,
Props: []Property{{
@@ -238,7 +238,7 @@
propOp: []propOp{{
op: "propfind",
name: "/dir",
- pnames: []xml.Name{{"DAV:", "getetag"}},
+ pnames: []xml.Name{{Space: "DAV:", Local: "getetag"}},
wantPropstats: []Propstat{{
Status: http.StatusNotFound,
Props: []Property{{
@@ -248,7 +248,7 @@
}, {
op: "propfind",
name: "/file",
- pnames: []xml.Name{{"DAV:", "getetag"}},
+ pnames: []xml.Name{{Space: "DAV:", Local: "getetag"}},
wantPropstats: []Propstat{{
Status: http.StatusOK,
Props: []Property{{
@@ -493,7 +493,7 @@
propOp: []propOp{{
op: "propfind",
name: "/dir",
- pnames: []xml.Name{{"foo:", "bar"}},
+ pnames: []xml.Name{{Space: "foo:", Local: "bar"}},
wantPropstats: []Propstat{{
Status: http.StatusNotFound,
Props: []Property{{
