net/http: deflake TestTransportRetryAfterGOAWAY

Drop a redundant Close of a net.Conn.

On Windows, writing to a closed connection will cause future
reads from the connection to fail, even if there is buffered
data available. When the test server writes a GOAWAY frame and
immediately closes the connection, this can result in the client
never seeing the GOAWAY. To avoid this, don't close server
connections until after all test functions have returned.

Fixes golang/go#59919

Change-Id: I82ed15870f3e6cd47f833a7a60b007b2fa2e15b0
Reviewed-on: https://go-review.googlesource.com/c/net/+/496056
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
1 file changed
tree: d9e35da3dce7a8966d6641ea34295e8834999dea
  1. bpf/
  2. context/
  3. dict/
  4. dns/
  5. html/
  6. http/
  7. http2/
  8. icmp/
  9. idna/
  10. internal/
  11. ipv4/
  12. ipv6/
  13. lif/
  14. nettest/
  15. netutil/
  16. proxy/
  17. publicsuffix/
  18. route/
  19. trace/
  20. webdav/
  21. websocket/
  22. xsrftoken/
  23. .gitattributes
  24. .gitignore
  25. codereview.cfg
  26. CONTRIBUTING.md
  27. go.mod
  28. go.sum
  29. LICENSE
  30. PATENTS
  31. README.md
README.md

Go Networking

Go Reference

This repository holds supplementary Go networking libraries.

Download/Install

The easiest way to install is to run go get -u golang.org/x/net. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.