tree d9e35da3dce7a8966d6641ea34295e8834999dea
parent abee42a2abc502cd1e66ada35c62cef6aec3c3a8
author Damien Neil <dneil@google.com> 1684430131 -0700
committer Damien Neil <dneil@google.com> 1684537124 +0000

net/http: deflake TestTransportRetryAfterGOAWAY

Drop a redundant Close of a net.Conn.

On Windows, writing to a closed connection will cause future
reads from the connection to fail, even if there is buffered
data available. When the test server writes a GOAWAY frame and
immediately closes the connection, this can result in the client
never seeing the GOAWAY. To avoid this, don't close server
connections until after all test functions have returned.

Fixes golang/go#59919

Change-Id: I82ed15870f3e6cd47f833a7a60b007b2fa2e15b0
Reviewed-on: https://go-review.googlesource.com/c/net/+/496056
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>