| commit | 6e4e7296867b5c082b3a1b4c3aa03051b7d11953 | [log] [tgz] |
|---|---|---|
| author | Bryan C. Mills <bcmills@google.com> | Fri Jun 04 12:10:41 2021 -0400 |
| committer | Bryan C. Mills <bcmills@google.com> | Tue Jun 08 18:58:56 2021 +0000 |
| tree | faa64c350395bc2324a47dcbac6b0ad3c3002c34 | |
| parent | ad21a28c145f7ca1cc3bc6e6510da8bfc37bdb4a [diff] |
modfile: clean up SetRequire
I started this change by expanding the documentation and tests for
SetRequire. Unfortunately, the tests failed when the existing
contents included duplicates of a module path:
--- FAIL: TestSetRequire/existing_duplicate (0.00s)
rule_test.go:1011: after Cleanup, len(Require) = 3; want 1
--- FAIL: TestSetRequire/existing_duplicate_multi (0.00s)
rule_test.go:1011: after Cleanup, len(Require) = 3; want 1
So then I fixed the detected bug, by updating the Line entries
(possibly marking them for removal) in the same loop that updates the
Require entries. (We don't need to loop over f.Syntax.Stmt separately
to remove deleted entries because f.Syntax.Cleanup already does that.)
For golang/go#45965
Change-Id: I1b665c0832112de2c4273628f266dc3d966fefdd
Reviewed-on: https://go-review.googlesource.com/c/mod/+/325230
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
This repository holds packages for writing tools that work directly with Go module mechanics. That is, it is for direct manipulation of Go modules themselves.
It is NOT about supporting general development tools that need to do things like load packages in module mode. That use case, where modules are incidental rather than the focus, should remain in x/tools, specifically x/tools/go/packages.
The specific case of loading packages should still be done by invoking the go command, which remains the single point of truth for package loading algorithms.