Remove me from list of bad receivers.
Signed-off-by: Joe Tsai <joetsai@google.com>
diff --git a/lint.go b/lint.go
index 3777f11..f98d9b9 100644
--- a/lint.go
+++ b/lint.go
@@ -1212,12 +1212,6 @@
})
}
-var badReceiverNames = map[string]bool{
- "me": true,
- "this": true,
- "self": true,
-}
-
// lintReceiverNames examines receiver names. It complains about inconsistent
// names used for the same type and names such as "this".
func (f *file) lintReceiverNames() {
@@ -1237,8 +1231,8 @@
f.errorf(n, 1, link(ref), category("naming"), `receiver name should not be an underscore`)
return true
}
- if badReceiverNames[name] {
- f.errorf(n, 1, link(ref), category("naming"), `receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"`)
+ if name == "this" || name == "self" {
+ f.errorf(n, 1, link(ref), category("naming"), `receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"`)
return true
}
recv := receiverType(fn)
diff --git a/testdata/receiver-names.go b/testdata/receiver-names.go
index 5fce725..6e51327 100644
--- a/testdata/receiver-names.go
+++ b/testdata/receiver-names.go
@@ -40,5 +40,10 @@
func (_ *bar) f7() { // MATCH /receiver name should not be an underscore/
}
+type multiError struct{}
+
+func (me multiError) f8() {
+}
+
// Regression test for a panic caused by ill-formed receiver type.
func (recv []*x.y) f()
