commit 679e9068802a09cfa9923490c3dc42883c50552c
author Cherry Zhang <cherryyz@google.com> Thu Feb 08 17:52:04 2018 -0500
committer Cherry Zhang <cherryyz@google.com> Fri Feb 09 16:41:55 2018 +0000
tree 1df350580f5ade6a172fb2b988839a32186968cf
parent 67e1d52aa3359c431efde82a6dca0b9ec6460f5e

gollvm: fix memory leak for decl vars

In Bfunction::localVariable, decl vars are not included in
valueVarMap_, therefore not deleted when the function is
destroyed. Fix the destructor to delete them.

Change-Id: I2f219a3505a3f85060bf4f3da1ee83421975cb24
Reviewed-on: https://go-review.googlesource.com/92975
Reviewed-by: Than McIntosh <thanm@google.com>

bridge/go-llvm-bfunction.cpp

diff --git a/bridge/go-llvm-bfunction.cpp b/bridge/go-llvm-bfunction.cpp
index dc24910..ab72a5a 100644
--- a/bridge/go-llvm-bfunction.cpp
+++ b/bridge/go-llvm-bfunction.cpp
@@ -54,6 +54,12 @@
   }
   for (auto &lab : labels_)
     delete lab;
+  for (auto &v : localVariables_) {
+    // only delete declvars here, others are in valueVarMap_
+    // and will be deleted below.
+    if (v->isDeclVar())
+      delete v;
+  }
   for (auto &kv : valueVarMap_)
     delete kv.second;
   assert(labelAddressPlaceholders_.empty());