commit 1ca71a857f54156561557b31a6274685ad891194
author Than McIntosh <thanm@google.com> Wed Aug 01 15:55:44 2018 -0400
committer Than McIntosh <thanm@google.com> Thu Aug 02 17:36:50 2018 +0000
tree db27f6e0c1dedc91d0967e542a57bb8653a73eea
parent 3b4668c1ffefffb31745fc8e13340d2490f1be99

gollvm: fix buglet in -gz

Change the implementation of the "-gz" to be consistent with Clang,
which treats it as a purely assembler-only option. Prior to this patch
the driver was passing "-compress-debug-sections" to both the assembler
and the linker, which is problematic (since the assembler will accept
that option without any args, while the linker always requires an
arg).

Change-Id: I3447a5d94f7a813c9bec61197ccbf95763ade82c
Reviewed-on: https://go-review.googlesource.com/127555
Reviewed-by: Cherry Zhang <cherryyz@google.com>

driver/GnuTools.cpp

diff --git a/driver/GnuTools.cpp b/driver/GnuTools.cpp
index 798ea11..71053e6 100644
--- a/driver/GnuTools.cpp
+++ b/driver/GnuTools.cpp
@@ -366,20 +366,6 @@
   // Add -m flag.
   addLDM(cmdArgs);
 
-  // FIXME: common this up with the assembler sequence above.
-  // Support for compressed debug.
-  llvm::opt::Arg *gzarg = args.getLastArg(gollvm::options::OPT_gz,
-                                          gollvm::options::OPT_gz_EQ);
-  if (gzarg != nullptr) {
-    if (gzarg->getOption().matches(gollvm::options::OPT_gz)) {
-      cmdArgs.push_back("-compress-debug-sections");
-    } else {
-      std::string cds("-compress-debug-sections=");
-      cds += gzarg->getValue();
-      cmdArgs.push_back(args.MakeArgString(cds));
-    }
-  }
-
   // Pick up correct directory for Go libraries.
   std::string golib("-L");
   golib += toolchain().driver().installedLibDir();