commit 1b2533ab8d13e7257fb5e03ede5673ae86a9b5aa
author Than McIntosh <thanm@google.com> Thu Jan 28 11:59:57 2021 -0500
committer Than McIntosh <thanm@google.com> Mon Feb 08 23:42:19 2021 +0000
tree 5142f59a308286d939a34660b2af65b0bdf5ea21
parent 3cb23e52e9602b1fb0661e7cf6b535fbfccb3f56

gollvm: update to check target dependency generation

Make all check targets dependent on libgotool.a, so as to avoid
having to maintain a list of checks that actually need it.

Change-Id: I018ca35e396bce03360351ee40a0811005a59810
Reviewed-on: https://go-review.googlesource.com/c/gollvm/+/290530
Trust: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>

libgo/CMakeLists.txt

diff --git a/libgo/CMakeLists.txt b/libgo/CMakeLists.txt
index 149ea02..0b6cf85 100644
--- a/libgo/CMakeLists.txt
+++ b/libgo/CMakeLists.txt
@@ -609,23 +609,6 @@
 #
 # Check target generation.
 #
-set(extra_check_libs_cmd_go_internal_cache "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_generate "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_get "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_load "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_lockedfile "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_imports "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_modconv "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_modfetch "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_modfetch_codehost "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_modfile "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_modload "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_module "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_mvs "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_search "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_web2 "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_go_internal_work "${libgo_binroot}/libgotool.a")
-set(extra_check_libs_cmd_vet_internal_cfg "${libgo_binroot}/libgotool.a")
 
 set(checktargets)
 
@@ -638,7 +621,11 @@
   # This will set 'packsrcs' and 'packopts'
   collect_package_inputs(${pack})
 
-  set(extralibs "${extra_check_libs_${ptarget}}")
+  set(extralibs "")
+  string(FIND "${ptarget}" "cmd_" out)
+  if("${out}" EQUAL 0)
+    set(extralibs "${libgo_binroot}/libgotool.a")
+  endif()
 
   # In some cases we want a different set of flags for the check
   # target, notable the runtime package (where the main build uses