commit 6f4bce815786ff3803741355f7f280e4e2c89668
author Ian Lance Taylor <iant@golang.org> Fri Oct 05 10:48:42 2018 -0700
committer Ian Lance Taylor <iant@golang.org> Thu Oct 18 23:25:42 2018 +0000
tree 713a95d14ad1760bf3e6f83b9e29fa34938cf15e
parent 9c985ce6f76dd65b8eb0e4b03c09ad0100712e04

compiler: add COMPARE_ALIASES flag for type compare and hash

Normally aliases compare as identical to the underlying type.  Add a
COMPARE_ALIASES flag to let them compare (and hash) differently.  This
will be used by later patches in this series.

Change-Id: I75b0f65d9be19b7adf77bead276f37cd3984d40d
Reviewed-on: https://go-review.googlesource.com/c/143021
Reviewed-by: Than McIntosh <thanm@google.com>

go/types.cc

diff --git a/go/types.cc b/go/types.cc
index e766c77..94b332a 100644
--- a/go/types.cc
+++ b/go/types.cc
@@ -349,9 +349,16 @@
       return (flags & COMPARE_ERRORS) == 0 ? true : t1 == t2;
     }
 
-  // Skip defined forward declarations.  Ignore aliases.
-  t1 = t1->unalias();
-  t2 = t2->unalias();
+  // Skip defined forward declarations.
+  t1 = t1->forwarded();
+  t2 = t2->forwarded();
+
+  if ((flags & COMPARE_ALIASES) == 0)
+    {
+      // Ignore aliases.
+      t1 = t1->unalias();
+      t2 = t2->unalias();
+    }
 
   if (t1 == t2)
     return true;
@@ -923,12 +930,17 @@
 unsigned int
 Type::hash_for_method(Gogo* gogo, int flags) const
 {
-  if (this->named_type() != NULL && this->named_type()->is_alias())
-    return this->named_type()->real_type()->hash_for_method(gogo, flags);
-  unsigned int ret = 0;
-  if (this->classification_ != TYPE_FORWARD)
-    ret += this->classification_;
-  return ret + this->do_hash_for_method(gogo, flags);
+  const Type* t = this->forwarded();
+  if (t->named_type() != NULL && t->named_type()->is_alias())
+    {
+      unsigned int r =
+	t->named_type()->real_type()->hash_for_method(gogo, flags);
+      if ((flags & Type::COMPARE_ALIASES) != 0)
+	r += TYPE_FORWARD;
+      return r;
+    }
+  unsigned int ret = t->classification_;
+  return ret + t->do_hash_for_method(gogo, flags);
 }
 
 // Default implementation of do_hash_for_method.  This is appropriate

go/types.h

diff --git a/go/types.h b/go/types.h
index 18cc257..c99b08a 100644
--- a/go/types.h
+++ b/go/types.h
@@ -574,6 +574,9 @@
   // struct field tags for purposes of type conversion.
   static const int COMPARE_TAGS = 2;
 
+  // Compare aliases: treat an alias to T as distinct from T.
+  static const int COMPARE_ALIASES = 4;
+
   // Return true if two types are identical.  If this returns false,
   // and REASON is not NULL, it may set *REASON.
   static bool