commit 1a74b8a22b2ff7f430729aa87ecb8cea7b5cdd70
author Than McIntosh <thanm@google.com> Fri Feb 15 11:16:56 2019 -0500
committer Ian Lance Taylor <iant@golang.org> Fri Feb 15 21:04:14 2019 +0000
tree 826104c10c56814356e58c0b7e29ad1f5869ae69
parent 0563f2d018cdb2cd685c254bac5ceb38396d0a27

compiler: write barrier check nil-check policy tweak

Tweak the recipe for generating writeBarrier loads to insure that the
dereference expr is marked as not requiring a nil check (not needed
for gccgo, but needed for gollvm).

Fixes https://gcc.gnu.org/PR89368

Change-Id: If057f1359c3e3e78612abc33d605d9e6908ec21c
Reviewed-on: https://go-review.googlesource.com/c/162904
Reviewed-by: Ian Lance Taylor <iant@golang.org>

go/wb.cc

diff --git a/go/wb.cc b/go/wb.cc
index 04619d3..1d12269 100644
--- a/go/wb.cc
+++ b/go/wb.cc
@@ -904,7 +904,8 @@
   ref = Expression::make_unary(OPERATOR_AND, ref, loc);
   ref = Expression::make_cast(unsafe_pointer_type, ref, loc);
   ref = Expression::make_cast(puint32_type, ref, loc);
-  ref = Expression::make_unary(OPERATOR_MULT, ref, loc);
+  ref = Expression::make_dereference(ref,
+                                     Expression::NIL_CHECK_NOT_NEEDED, loc);
   Expression* zero = Expression::make_integer_ul(0, ref->type(), loc);
   Expression* cond = Expression::make_binary(OPERATOR_EQEQ, ref, zero, loc);