commit 0036bd04d077f8bbe5aa9a62fb8830c53068209e
author Than McIntosh <thanm@google.com> Mon Jul 17 14:31:49 2017 -0400
committer Ian Lance Taylor <iant@golang.org> Tue Jul 18 22:30:04 2017 +0000
tree 1b18df120bfc86687163adf455ec9177c64f30d3
parent 21775ae119830810d9e415a02e85349f4190c68c

compiler: pass correct 'function' flag to circular_pointer_type

The code in Named_type::do_get_backend was not passing the correct
flag value for circular function types to Backend::circular_pointer_type
(it was always setting this flag to false). Pass a true value if the
type being converted is a function type.

Change-Id: I3255599d30e30ae657ded853526d90a9537c2c22
Reviewed-on: https://go-review.googlesource.com/49330
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

go/types.cc

diff --git a/go/types.cc b/go/types.cc
index b2756fd..ca5f512 100644
--- a/go/types.cc
+++ b/go/types.cc
@@ -10994,13 +10994,13 @@
       if (this->seen_in_get_backend_)
 	{
 	  this->is_circular_ = true;
-	  return gogo->backend()->circular_pointer_type(bt, false);
+	  return gogo->backend()->circular_pointer_type(bt, true);
 	}
       this->seen_in_get_backend_ = true;
       bt1 = Type::get_named_base_btype(gogo, base);
       this->seen_in_get_backend_ = false;
       if (this->is_circular_)
-	bt1 = gogo->backend()->circular_pointer_type(bt, false);
+	bt1 = gogo->backend()->circular_pointer_type(bt, true);
       if (!gogo->backend()->set_placeholder_pointer_type(bt, bt1))
 	bt = gogo->backend()->error_type();
       return bt;