Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 1 | // Copyright 2009 The Go Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style |
| 3 | // license that can be found in the LICENSE file. |
| 4 | |
Russ Cox | 3b864e4 | 2009-08-12 13:18:37 -0700 | [diff] [blame] | 5 | package flag_test |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 6 | |
| 7 | import ( |
Brad Fitzpatrick | b79ba6a | 2012-01-27 09:23:06 -0800 | [diff] [blame^] | 8 | "bytes" |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 9 | . "flag" |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 10 | "fmt" |
Russ Cox | ed7c3f3 | 2010-12-07 13:19:01 -0500 | [diff] [blame] | 11 | "os" |
Rob Pike | 034ca39 | 2011-03-10 12:42:31 -0800 | [diff] [blame] | 12 | "sort" |
Brad Fitzpatrick | b79ba6a | 2012-01-27 09:23:06 -0800 | [diff] [blame^] | 13 | "strings" |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 14 | "testing" |
David Symonds | cf506f6 | 2011-12-23 16:29:38 +1100 | [diff] [blame] | 15 | "time" |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 16 | ) |
| 17 | |
| 18 | var ( |
David Symonds | cf506f6 | 2011-12-23 16:29:38 +1100 | [diff] [blame] | 19 | test_bool = Bool("test_bool", false, "bool value") |
| 20 | test_int = Int("test_int", 0, "int value") |
| 21 | test_int64 = Int64("test_int64", 0, "int64 value") |
| 22 | test_uint = Uint("test_uint", 0, "uint value") |
| 23 | test_uint64 = Uint64("test_uint64", 0, "uint64 value") |
| 24 | test_string = String("test_string", "0", "string value") |
| 25 | test_float64 = Float64("test_float64", 0, "float64 value") |
| 26 | test_duration = Duration("test_duration", 0, "time.Duration value") |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 27 | ) |
| 28 | |
Rob Pike | 575257d | 2009-02-16 21:55:37 -0800 | [diff] [blame] | 29 | func boolString(s string) string { |
| 30 | if s == "0" { |
Robert Griesemer | 40621d5 | 2009-11-09 12:07:39 -0800 | [diff] [blame] | 31 | return "false" |
Rob Pike | 575257d | 2009-02-16 21:55:37 -0800 | [diff] [blame] | 32 | } |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 33 | return "true" |
Rob Pike | 575257d | 2009-02-16 21:55:37 -0800 | [diff] [blame] | 34 | } |
| 35 | |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 36 | func TestEverything(t *testing.T) { |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 37 | m := make(map[string]*Flag) |
| 38 | desired := "0" |
Russ Cox | 3b864e4 | 2009-08-12 13:18:37 -0700 | [diff] [blame] | 39 | visitor := func(f *Flag) { |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 40 | if len(f.Name) > 5 && f.Name[0:5] == "test_" { |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 41 | m[f.Name] = f |
| 42 | ok := false |
Rob Pike | 575257d | 2009-02-16 21:55:37 -0800 | [diff] [blame] | 43 | switch { |
| 44 | case f.Value.String() == desired: |
Robert Griesemer | 40621d5 | 2009-11-09 12:07:39 -0800 | [diff] [blame] | 45 | ok = true |
Rob Pike | 575257d | 2009-02-16 21:55:37 -0800 | [diff] [blame] | 46 | case f.Name == "test_bool" && f.Value.String() == boolString(desired): |
Robert Griesemer | 40621d5 | 2009-11-09 12:07:39 -0800 | [diff] [blame] | 47 | ok = true |
David Symonds | cf506f6 | 2011-12-23 16:29:38 +1100 | [diff] [blame] | 48 | case f.Name == "test_duration" && f.Value.String() == desired+"s": |
| 49 | ok = true |
Rob Pike | 575257d | 2009-02-16 21:55:37 -0800 | [diff] [blame] | 50 | } |
| 51 | if !ok { |
Robert Griesemer | 40621d5 | 2009-11-09 12:07:39 -0800 | [diff] [blame] | 52 | t.Error("Visit: bad value", f.Value.String(), "for", f.Name) |
Rob Pike | 575257d | 2009-02-16 21:55:37 -0800 | [diff] [blame] | 53 | } |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 54 | } |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 55 | } |
| 56 | VisitAll(visitor) |
David Symonds | cf506f6 | 2011-12-23 16:29:38 +1100 | [diff] [blame] | 57 | if len(m) != 8 { |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 58 | t.Error("VisitAll misses some flags") |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 59 | for k, v := range m { |
Robert Griesemer | 40621d5 | 2009-11-09 12:07:39 -0800 | [diff] [blame] | 60 | t.Log(k, *v) |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 61 | } |
| 62 | } |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 63 | m = make(map[string]*Flag) |
| 64 | Visit(visitor) |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 65 | if len(m) != 0 { |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 66 | t.Errorf("Visit sees unset flags") |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 67 | for k, v := range m { |
Robert Griesemer | 40621d5 | 2009-11-09 12:07:39 -0800 | [diff] [blame] | 68 | t.Log(k, *v) |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 69 | } |
| 70 | } |
Rob Pike | 575257d | 2009-02-16 21:55:37 -0800 | [diff] [blame] | 71 | // Now set all flags |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 72 | Set("test_bool", "true") |
| 73 | Set("test_int", "1") |
| 74 | Set("test_int64", "1") |
| 75 | Set("test_uint", "1") |
| 76 | Set("test_uint64", "1") |
| 77 | Set("test_string", "1") |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 78 | Set("test_float64", "1") |
David Symonds | cf506f6 | 2011-12-23 16:29:38 +1100 | [diff] [blame] | 79 | Set("test_duration", "1s") |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 80 | desired = "1" |
| 81 | Visit(visitor) |
David Symonds | cf506f6 | 2011-12-23 16:29:38 +1100 | [diff] [blame] | 82 | if len(m) != 8 { |
Robert Griesemer | 1c72959 | 2009-12-15 15:27:16 -0800 | [diff] [blame] | 83 | t.Error("Visit fails after set") |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 84 | for k, v := range m { |
Robert Griesemer | 40621d5 | 2009-11-09 12:07:39 -0800 | [diff] [blame] | 85 | t.Log(k, *v) |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 86 | } |
| 87 | } |
Rob Pike | 034ca39 | 2011-03-10 12:42:31 -0800 | [diff] [blame] | 88 | // Now test they're visited in sort order. |
| 89 | var flagNames []string |
| 90 | Visit(func(f *Flag) { flagNames = append(flagNames, f.Name) }) |
| 91 | if !sort.StringsAreSorted(flagNames) { |
| 92 | t.Errorf("flag names not sorted: %v", flagNames) |
| 93 | } |
Rob Pike | bbc190b | 2009-02-16 19:43:15 -0800 | [diff] [blame] | 94 | } |
Rob Pike | 570af81 | 2010-03-29 17:37:22 -0700 | [diff] [blame] | 95 | |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 96 | func TestUsage(t *testing.T) { |
| 97 | called := false |
| 98 | ResetForTesting(func() { called = true }) |
Rob Pike | f4fe688 | 2011-05-22 09:22:00 +1000 | [diff] [blame] | 99 | if CommandLine().Parse([]string{"-x"}) == nil { |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 100 | t.Error("parse did not fail for unknown flag") |
| 101 | } |
| 102 | if !called { |
| 103 | t.Error("did not call Usage for unknown flag") |
| 104 | } |
| 105 | } |
| 106 | |
Rob Pike | f4fe688 | 2011-05-22 09:22:00 +1000 | [diff] [blame] | 107 | func testParse(f *FlagSet, t *testing.T) { |
Russ Cox | 2cc4a54 | 2011-08-31 17:38:41 -0400 | [diff] [blame] | 108 | if f.Parsed() { |
| 109 | t.Error("f.Parse() = true before Parse") |
| 110 | } |
Rob Pike | f4fe688 | 2011-05-22 09:22:00 +1000 | [diff] [blame] | 111 | boolFlag := f.Bool("bool", false, "bool value") |
| 112 | bool2Flag := f.Bool("bool2", false, "bool2 value") |
| 113 | intFlag := f.Int("int", 0, "int value") |
| 114 | int64Flag := f.Int64("int64", 0, "int64 value") |
| 115 | uintFlag := f.Uint("uint", 0, "uint value") |
| 116 | uint64Flag := f.Uint64("uint64", 0, "uint64 value") |
| 117 | stringFlag := f.String("string", "0", "string value") |
| 118 | float64Flag := f.Float64("float64", 0, "float64 value") |
David Symonds | cf506f6 | 2011-12-23 16:29:38 +1100 | [diff] [blame] | 119 | durationFlag := f.Duration("duration", 5*time.Second, "time.Duration value") |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 120 | extra := "one-extra-argument" |
| 121 | args := []string{ |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 122 | "-bool", |
| 123 | "-bool2=true", |
| 124 | "--int", "22", |
Luuk van Dijk | 37b1787 | 2011-02-11 12:23:54 +0100 | [diff] [blame] | 125 | "--int64", "0x23", |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 126 | "-uint", "24", |
| 127 | "--uint64", "25", |
| 128 | "-string", "hello", |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 129 | "-float64", "2718e28", |
David Symonds | cf506f6 | 2011-12-23 16:29:38 +1100 | [diff] [blame] | 130 | "-duration", "2m", |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 131 | extra, |
| 132 | } |
Rob Pike | f4fe688 | 2011-05-22 09:22:00 +1000 | [diff] [blame] | 133 | if err := f.Parse(args); err != nil { |
| 134 | t.Fatal(err) |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 135 | } |
Russ Cox | 2cc4a54 | 2011-08-31 17:38:41 -0400 | [diff] [blame] | 136 | if !f.Parsed() { |
| 137 | t.Error("f.Parse() = false after Parse") |
| 138 | } |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 139 | if *boolFlag != true { |
| 140 | t.Error("bool flag should be true, is ", *boolFlag) |
| 141 | } |
| 142 | if *bool2Flag != true { |
| 143 | t.Error("bool2 flag should be true, is ", *bool2Flag) |
| 144 | } |
| 145 | if *intFlag != 22 { |
| 146 | t.Error("int flag should be 22, is ", *intFlag) |
| 147 | } |
Luuk van Dijk | 37b1787 | 2011-02-11 12:23:54 +0100 | [diff] [blame] | 148 | if *int64Flag != 0x23 { |
| 149 | t.Error("int64 flag should be 0x23, is ", *int64Flag) |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 150 | } |
| 151 | if *uintFlag != 24 { |
| 152 | t.Error("uint flag should be 24, is ", *uintFlag) |
| 153 | } |
| 154 | if *uint64Flag != 25 { |
| 155 | t.Error("uint64 flag should be 25, is ", *uint64Flag) |
| 156 | } |
| 157 | if *stringFlag != "hello" { |
| 158 | t.Error("string flag should be `hello`, is ", *stringFlag) |
| 159 | } |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 160 | if *float64Flag != 2718e28 { |
| 161 | t.Error("float64 flag should be 2718e28, is ", *float64Flag) |
| 162 | } |
David Symonds | cf506f6 | 2011-12-23 16:29:38 +1100 | [diff] [blame] | 163 | if *durationFlag != 2*time.Minute { |
| 164 | t.Error("duration flag should be 2m, is ", *durationFlag) |
| 165 | } |
Rob Pike | f4fe688 | 2011-05-22 09:22:00 +1000 | [diff] [blame] | 166 | if len(f.Args()) != 1 { |
| 167 | t.Error("expected one argument, got", len(f.Args())) |
| 168 | } else if f.Args()[0] != extra { |
| 169 | t.Errorf("expected argument %q got %q", extra, f.Args()[0]) |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 170 | } |
| 171 | } |
| 172 | |
Rob Pike | f4fe688 | 2011-05-22 09:22:00 +1000 | [diff] [blame] | 173 | func TestParse(t *testing.T) { |
| 174 | ResetForTesting(func() { t.Error("bad parse") }) |
| 175 | testParse(CommandLine(), t) |
| 176 | } |
| 177 | |
| 178 | func TestFlagSetParse(t *testing.T) { |
| 179 | testParse(NewFlagSet("test", ContinueOnError), t) |
| 180 | } |
| 181 | |
| 182 | // Declare a user-defined flag type. |
Rob Pike | 570af81 | 2010-03-29 17:37:22 -0700 | [diff] [blame] | 183 | type flagVar []string |
| 184 | |
| 185 | func (f *flagVar) String() string { |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 186 | return fmt.Sprint([]string(*f)) |
Rob Pike | 570af81 | 2010-03-29 17:37:22 -0700 | [diff] [blame] | 187 | } |
| 188 | |
David Symonds | 98b9047 | 2011-12-25 16:12:26 +1100 | [diff] [blame] | 189 | func (f *flagVar) Set(value string) error { |
Russ Cox | 69c4e93 | 2010-10-27 19:47:23 -0700 | [diff] [blame] | 190 | *f = append(*f, value) |
David Symonds | 98b9047 | 2011-12-25 16:12:26 +1100 | [diff] [blame] | 191 | return nil |
Rob Pike | 570af81 | 2010-03-29 17:37:22 -0700 | [diff] [blame] | 192 | } |
| 193 | |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 194 | func TestUserDefined(t *testing.T) { |
Russ Cox | 1505cae | 2011-09-15 17:04:51 -0400 | [diff] [blame] | 195 | var flags FlagSet |
| 196 | flags.Init("test", ContinueOnError) |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 197 | var v flagVar |
Rob Pike | f4fe688 | 2011-05-22 09:22:00 +1000 | [diff] [blame] | 198 | flags.Var(&v, "v", "usage") |
| 199 | if err := flags.Parse([]string{"-v", "1", "-v", "2", "-v=3"}); err != nil { |
| 200 | t.Error(err) |
Rob Pike | 6431b98 | 2010-04-06 16:46:52 -0700 | [diff] [blame] | 201 | } |
| 202 | if len(v) != 3 { |
| 203 | t.Fatal("expected 3 args; got ", len(v)) |
| 204 | } |
| 205 | expect := "[1 2 3]" |
| 206 | if v.String() != expect { |
| 207 | t.Errorf("expected value %q got %q", expect, v.String()) |
| 208 | } |
Rob Pike | 570af81 | 2010-03-29 17:37:22 -0700 | [diff] [blame] | 209 | } |
Russ Cox | ed7c3f3 | 2010-12-07 13:19:01 -0500 | [diff] [blame] | 210 | |
Brad Fitzpatrick | b79ba6a | 2012-01-27 09:23:06 -0800 | [diff] [blame^] | 211 | func TestSetOutput(t *testing.T) { |
| 212 | var flags FlagSet |
| 213 | var buf bytes.Buffer |
| 214 | flags.SetOutput(&buf) |
| 215 | flags.Init("test", ContinueOnError) |
| 216 | flags.Parse([]string{"-unknown"}) |
| 217 | if out := buf.String(); !strings.Contains(out, "-unknown") { |
| 218 | t.Logf("expected output mentioning unknown; got %q", out) |
| 219 | } |
| 220 | } |
| 221 | |
Rob Pike | f4fe688 | 2011-05-22 09:22:00 +1000 | [diff] [blame] | 222 | // This tests that one can reset the flags. This still works but not well, and is |
| 223 | // superseded by FlagSet. |
Russ Cox | ed7c3f3 | 2010-12-07 13:19:01 -0500 | [diff] [blame] | 224 | func TestChangingArgs(t *testing.T) { |
| 225 | ResetForTesting(func() { t.Fatal("bad parse") }) |
| 226 | oldArgs := os.Args |
| 227 | defer func() { os.Args = oldArgs }() |
| 228 | os.Args = []string{"cmd", "-before", "subcmd", "-after", "args"} |
| 229 | before := Bool("before", false, "") |
Rob Pike | f4fe688 | 2011-05-22 09:22:00 +1000 | [diff] [blame] | 230 | if err := CommandLine().Parse(os.Args[1:]); err != nil { |
| 231 | t.Fatal(err) |
| 232 | } |
Russ Cox | ed7c3f3 | 2010-12-07 13:19:01 -0500 | [diff] [blame] | 233 | cmd := Arg(0) |
| 234 | os.Args = Args() |
| 235 | after := Bool("after", false, "") |
| 236 | Parse() |
| 237 | args := Args() |
| 238 | |
| 239 | if !*before || cmd != "subcmd" || !*after || len(args) != 1 || args[0] != "args" { |
Rob Pike | 70113b4 | 2010-12-08 16:25:14 -0500 | [diff] [blame] | 240 | t.Fatalf("expected true subcmd true [args] got %v %v %v %v", *before, cmd, *after, args) |
Russ Cox | ed7c3f3 | 2010-12-07 13:19:01 -0500 | [diff] [blame] | 241 | } |
| 242 | } |
Rob Pike | e44853c | 2011-07-11 09:35:50 +1000 | [diff] [blame] | 243 | |
| 244 | // Test that -help invokes the usage message and returns ErrHelp. |
| 245 | func TestHelp(t *testing.T) { |
| 246 | var helpCalled = false |
| 247 | fs := NewFlagSet("help test", ContinueOnError) |
| 248 | fs.Usage = func() { helpCalled = true } |
| 249 | var flag bool |
| 250 | fs.BoolVar(&flag, "flag", false, "regular flag") |
| 251 | // Regular flag invocation should work |
| 252 | err := fs.Parse([]string{"-flag=true"}) |
| 253 | if err != nil { |
| 254 | t.Fatal("expected no error; got ", err) |
| 255 | } |
| 256 | if !flag { |
| 257 | t.Error("flag was not set by -flag") |
| 258 | } |
| 259 | if helpCalled { |
| 260 | t.Error("help called for regular flag") |
| 261 | helpCalled = false // reset for next test |
| 262 | } |
| 263 | // Help flag should work as expected. |
| 264 | err = fs.Parse([]string{"-help"}) |
| 265 | if err == nil { |
| 266 | t.Fatal("error expected") |
| 267 | } |
| 268 | if err != ErrHelp { |
| 269 | t.Fatal("expected ErrHelp; got ", err) |
| 270 | } |
| 271 | if !helpCalled { |
| 272 | t.Fatal("help was not called") |
| 273 | } |
| 274 | // If we define a help flag, that should override. |
| 275 | var help bool |
| 276 | fs.BoolVar(&help, "help", false, "help flag") |
| 277 | helpCalled = false |
| 278 | err = fs.Parse([]string{"-help"}) |
| 279 | if err != nil { |
| 280 | t.Fatal("expected no error for defined -help; got ", err) |
| 281 | } |
| 282 | if helpCalled { |
| 283 | t.Fatal("help was called; should not have been for defined help flag") |
| 284 | } |
| 285 | } |