path/filepath: keep the trailing separator on GLOBALROOT device paths

volumeNameLen treats the component after a device prefix as the volume
name, which is what keeps Clean from removing the trailing separator of
a volume root. GLOBALROOT is not a volume: it links to the root of the
NT object namespace, and the volume is named by the two components
after it, so Clean stripped the separator from paths like
\\?\GLOBALROOT\Device\HarddiskVolume1\.

That separator decides what the path refers to: with it the volume's
root directory, without it the raw device. Windows hands these paths
out, notably from the Shadow Copy API.

Consume the two components after GLOBALROOT, as a UNC host and share
already are. Object namespace paths can nest deeper; those are still
not handled.

Fixes #67880

Change-Id: I9780595eadbc8efc77d396edc20908d2c5d48e7d
Reviewed-on: https://go-review.googlesource.com/c/go/+/819060
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2 files changed
tree: b5337a12f01e46686ee10ddd6a4f4414667c86a8
  1. .github/
  2. api/
  3. doc/
  4. lib/
  5. misc/
  6. src/
  7. test/
  8. .gitattributes
  9. .gitignore
  10. codereview.cfg
  11. CONTRIBUTING.md
  12. go.env
  13. LICENSE
  14. PATENTS
  15. README.md
  16. SECURITY.md
README.md

The Go Programming Language

Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.

Gopher image Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.

Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.

Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.

Download and Install

Binary Distributions

Official binary distributions are available at https://go.dev/dl/.

After downloading a binary release, visit https://go.dev/doc/install for installation instructions.

Install From Source

If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.

Contributing

Go is the work of thousands of contributors. We appreciate your help!

To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.

Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.