runtime: tell the race detector about synchronization on mainInitDone

CL 743940 puts an atomic bool initialization-done channel, which
is a nice optimization. In race mode, however, the atomic bool
does not have race instrumentation, so the race detector doesn't
know the happens-before edge between the initialization and the
cgo callback.

To tell the race detector about this synchronization, just use the
channel unconditionally in race mode. Channel operations have the
proper race instrumentation. Alternatively, we could explicitly
instrument the atomic boolean operations.

TODO: write a test.

Change-Id: I466b20a46cd39d2bbe2149a9009e1a01b15891e2
Reviewed-on: https://go-review.googlesource.com/c/go/+/746581
Reviewed-by: Ian Lance Taylor <iant@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
1 file changed
tree: 30beba378423a143391fb59c6c62219b89022a7f
  1. .github/
  2. api/
  3. doc/
  4. lib/
  5. misc/
  6. src/
  7. test/
  8. .gitattributes
  9. .gitignore
  10. codereview.cfg
  11. CONTRIBUTING.md
  12. go.env
  13. LICENSE
  14. PATENTS
  15. README.md
  16. SECURITY.md
README.md

The Go Programming Language

Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.

Gopher image Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.

Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.

Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.

Download and Install

Binary Distributions

Official binary distributions are available at https://go.dev/dl/.

After downloading a binary release, visit https://go.dev/doc/install for installation instructions.

Install From Source

If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.

Contributing

Go is the work of thousands of contributors. We appreciate your help!

To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.

Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.