| commit | dffc915b2daec7ad81524e97f7f5cf72733d3586 | [log] [tgz] |
|---|---|---|
| author | Keith Randall <khr@golang.org> | Tue May 08 08:10:17 2018 -0700 |
| committer | Keith Randall <khr@golang.org> | Tue May 08 19:13:58 2018 +0000 |
| tree | cac5b2b0702300b9afe3f2154ac8d39575fec2e4 | |
| parent | 941b3b77648bb307c71d29b81b03349584f876e6 [diff] |
cmd/compile: mark modify ops as both read and write If the modify ops operate on a variable, we should tell the liveness pass that the variable is still live before the instruction. This looks like a bug, but I don't think there's any way to trigger it at the moment. It only matters for pointer-containing values, and the modify ops don't normally work on pointers. Even when I reach for unsafe.Pointer tricks, I can't get ADDLmodify to work on pointers, as there's always a Convert or VarDef preventing the coalescing. TL;DR I can't figure out a test for this. But we should probably fix it anyway. Change-Id: I971c62616dec51a33788b7634e6478e1bfcd6260 Reviewed-on: https://go-review.googlesource.com/112157 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.