go/types, types2: don't build unnecessary error strings in implements When accessing (*Checker).implements from types.AssignableTo or types.ComparableTo, we don't need to build error strings -- they won't be used. This string manipulation showed up as a hot spot in gopls completion, which checks a lot of type predicates when searching for candidate completions. This CL yields the following results for gopls' completion benchmarks: StructCompletion-8 24.7ms ±34% 26.0ms ±17% ~ (p=0.447 n=10+9) ImportCompletion-8 1.41ms ± 2% 1.45ms ± 4% +2.42% (p=0.027 n=8+9) SliceCompletion-8 27.0ms ±18% 25.2ms ± 3% -6.67% (p=0.008 n=9+8) FuncDeepCompletion-8 57.6ms ± 4% 22.4ms ± 4% -61.18% (p=0.000 n=8+9) CompletionFollowingEdit-8 157ms ±13% 103ms ±15% -34.70% (p=0.000 n=10+10) Notably, deep completion (which searches many candidates) is almost 3x faster after this change. Fixes #54172 Change-Id: If8303a411aed3a20bd91f7b61e346d703084166c Reviewed-on: https://go-review.googlesource.com/c/go/+/423360 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.