| commit | be003bd00b14fa29cd0876fb4fab627a007e2bbf | [log] [tgz] |
|---|---|---|
| author | Cherry Mui <cherryyz@google.com> | Fri Apr 26 21:47:19 2024 -0400 |
| committer | Cherry Mui <cherryyz@google.com> | Mon May 06 21:13:43 2024 +0000 |
| tree | 95f9724a3df6e274384842cc23f2c128e4c434db | |
| parent | be29a02161eae9aa7519496e3d058b3214f91508 [diff] |
runtime: don't re-raise ignored signal If a signal lands on a non-Go thread, and Go code doesn't want to handle it, currently we re-raise the signal in the signal handler after uninstalling our handler, so the C code can handle it. But if there is no C signal handler and the signal is ignored, there is no need to re-raise the signal. Just ignore it. This avoids uninstalling and reinstalling our handler, which, for some reason, changes errno when TSAN is used. And TSAN does not like errno being changed in the signal handler. Not really sure if this is the bset of complete fix, but it does fix the immediate problem, and it seems a reasonable thing to do by itself. Test case is CL 581722. Fixes #66427. Change-Id: I7a043d53059f1ff4080f4fc8ef4065d76ee7d78a Reviewed-on: https://go-review.googlesource.com/c/go/+/582077 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.