| commit | bb929b7452b5b8a6a584a94a110c98b0c6543a6e | [log] [tgz] |
|---|---|---|
| author | Matthew Dempsky <mdempsky@google.com> | Thu Mar 12 12:14:02 2020 -0700 |
| committer | Matthew Dempsky <mdempsky@google.com> | Mon Mar 23 03:56:18 2020 +0000 |
| tree | 1b1df30c16ef93aa8f6127df3cfe978afe7d68f7 | |
| parent | 0c302459968511865ec6a5ee4ff2172e4e54cef8 [diff] |
cmd/compile: skip generating args_stackmap for "pulled" funcs In golang.org/cl/171464, we cleaned up generation of .stkobj linker symbols, but we couldn't figure out why a similar cleanup to .args_stackmap linker symbols caused problems. The issue is that we only need/want to generate .args_stackmap for functions that are implemented in assembly in the same package. When "pulling" a function from another package via //go:linkname, we can safely skip emitting .args_stackmap, because compiling that package will have generated it, if necessary. Fixes #31615. Change-Id: If8680aa7dd5b4e8f268b6b032d746f1b8536c867 Reviewed-on: https://go-review.googlesource.com/c/go/+/223238 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Keith Randall <khr@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.