| commit | a9a1217112aa8f5e01fe2f3e5f203ac880dbd566 | [log] [tgz] |
|---|---|---|
| author | Cherry Zhang <cherryyz@google.com> | Thu Jun 25 22:22:59 2020 -0400 |
| committer | Cherry Zhang <cherryyz@google.com> | Fri Jun 26 14:25:58 2020 +0000 |
| tree | 7ca9e8a38188b2dda3504ab302f2643a57e0588b | |
| parent | 1fdf5ba50cf67d28dffb4a4f0e29fcb053d660ad [diff] |
[dev.link] cmd/link: handle runtime.text/etext symbols more consistently Currently, on most platforms, the start/end symbols runtime.text and runtime.etext are defined in symtab pass and assigned values in address pass. In some cases (darwin+dynlink or AIX+external), however, they are defined and assigned values in textaddress pass (because they need non-zero sizes). Then their values get overwritten in address pass. This is bad. The linker expects their values to be consistent. In particular, in CL 239281, findfunctab is split to two parts. The two parts need to have a consistent view of the start/end symbols. If its value changes in between, bad things can happen. This CL fixes it by always defining runtime.text/etext symbols in the textaddress pass. Fix darwin and AIX builds. Change-Id: Ifdc1bcb69d99be1b7e5b4fd31d473650c03e3b9d Reviewed-on: https://go-review.googlesource.com/c/go/+/240065 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jeremy Faller <jeremy@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.