| commit | e78e654c1de0a7bfe0314d6954d42b046f14f1bb | [log] [tgz] |
|---|---|---|
| author | Adam Langley <agl@golang.org> | Mon Jul 27 16:54:30 2015 -0700 |
| committer | Adam Langley <agl@golang.org> | Wed Sep 30 00:59:15 2015 +0000 |
| tree | 1a18cb41be03fcc1dd23b8adcf961faab534f577 | |
| parent | 8ee0261865bea69f1a39e04a539e1152b7ba578d [diff] |
crypto/x509: parse CSRs with a critical flag in the requested extensions. The format for a CSR is horribly underspecified and we had a mistake. The code was parsing the attributes from the CSR as a pkix.AttributeTypeAndValueSET, which is only almost correct: it works so long as the requested extensions don't contain the optional “critical” flag. Unfortunately this mistake is exported somewhat in the API and the Attributes field of a CSR actually has the wrong type. I've moved this field to the bottom of the structure and updated the comment to reflect this. The Extensions and other fields of the CSR structure can be saved however and this change does that. Fixes #11897. Change-Id: If8e2f5c21934800b72b041e38691efc3e897ecf1 Reviewed-on: https://go-review.googlesource.com/12717 Reviewed-by: Rob Pike <r@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
For documentation about how to install and use Go, visit https://golang.org/ or load doc/install-source.html in your web browser.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Please report issues here: https://golang.org/issue/new
Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
If you have just untarred a binary Go distribution, you need to set the environment variable $GOROOT to the full path of the go directory (the one containing this file). You can omit the variable if you unpack it into /usr/local/go, or if you rebuild from sources by running all.bash (see doc/install-source.html). You should also add the Go binary directory $GOROOT/bin to your shell's path.
For example, if you extracted the tar file into $HOME/go, you might put the following in your .profile:
export GOROOT=$HOME/go export PATH=$PATH:$GOROOT/bin
See https://golang.org/doc/install or doc/install.html for more details.