| commit | a4be24cbe6b10ee66674834d571c196622ff55ed | [log] [tgz] |
|---|---|---|
| author | Dave Cheney <dave@cheney.net> | Wed Mar 23 13:27:49 2016 +1100 |
| committer | Dave Cheney <dave@cheney.net> | Wed Mar 23 10:59:55 2016 +0000 |
| tree | 50f6199b6cd6c9076bf014e91845074e4f9f6821 | |
| parent | 1374515a1cf2279c2e47a4ee03a3616781814ad0 [diff] |
cmd/compile/internal/gc: remove redundant Nod(OXXX, ...) pattern
The pattern
n := Nod(OXXX, nil, nil)
Nodconst(n, ...)
was a leftover from the C days where n must be heap allocated.
No change in benchmarks, none expected as n escapes anyway.
name old time/op new time/op delta
Template 391ms ± 6% 388ms ± 5% ~ (p=0.659 n=20+20)
GoTypes 1.27s ± 1% 1.27s ± 2% ~ (p=0.828 n=18+20)
Compiler 6.16s ± 2% 6.15s ± 1% ~ (p=0.947 n=20+20)
name old alloc/op new alloc/op delta
Template 63.7MB ± 0% 63.7MB ± 0% ~ (p=0.414 n=20+20)
GoTypes 219MB ± 0% 219MB ± 0% ~ (p=0.904 n=20+20)
Compiler 980MB ± 0% 980MB ± 0% +0.00% (p=0.007 n=20+19)
name old allocs/op new allocs/op delta
Template 586k ± 0% 586k ± 0% ~ (p=0.564 n=19+20)
GoTypes 1.80M ± 0% 1.80M ± 0% ~ (p=0.718 n=20+20)
Compiler 7.74M ± 0% 7.74M ± 0% ~ (p=0.358 n=20+20)
The reuse of nc in multiple overlapping scopes in walk.go is the worst.
Change-Id: I4ed6a63f7ffbfff68124ad609f6e3a68d95cbbba
Reviewed-on: https://go-review.googlesource.com/21015
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
For documentation about how to install and use Go, visit https://golang.org/ or load doc/install-source.html in your web browser.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
If you have just untarred a binary Go distribution, you need to set the environment variable $GOROOT to the full path of the go directory (the one containing this file). You can omit the variable if you unpack it into /usr/local/go, or if you rebuild from sources by running all.bash (see doc/install-source.html). You should also add the Go binary directory $GOROOT/bin to your shell's path.
For example, if you extracted the tar file into $HOME/go, you might put the following in your .profile:
export GOROOT=$HOME/go export PATH=$PATH:$GOROOT/bin
See https://golang.org/doc/install or doc/install.html for more details.