| commit | 5cc5576a9cff098e6e47397ee32cb250de43d814 | [log] [tgz] |
|---|---|---|
| author | Cherry Zhang <cherryyz@google.com> | Sun Apr 04 12:46:21 2021 -0400 |
| committer | Cherry Zhang <cherryyz@google.com> | Mon Apr 05 17:27:18 2021 +0000 |
| tree | a77aee03cf376effa735a623bf924b0d98046875 | |
| parent | 45e87cd3ecfe5e579a06493ef8cd43ce9947262c [diff] |
cmd/compile: untangle Wrapper and ABIWrapper flags Currently, there are Wrapper and ABIWrapper attributes. Wrapper is set when compiler generates an wrapper function (e.g. method wrapper). ABIWrapper is set when compiler generates an ABI wrapper. It also sets Wrapper flag for ABI wrappers. Currently, they have the following meanings: - Wrapper flag hides the frame from (normal) traceback. - Wrapper flag enables special panic+recover adjustment, so it can correctly recover when a wrapper function is deferred. - ABIWrapper flag disables the panic+recover adjustment, because we never defer an ABI wrapper that can recover. This CL changes them to: - Both Wrapper and ABIWrapper flags hide the frame from (normal) traceback. (Setting one is enough.) - Wrapper flag enables special panic+recover adjustment. ABIWrapper flag no longer has effect on this. This makes it clearer if we do want an ABI wrapper that also does the panic+recover adjustment. In the old mechanism we'd have to unset ABIWrapper flag, even if the function is actually an ABI wrapper. In the new mechanism we just need to set both ABIWrapper and Wrapper flags. Updates #40724. Change-Id: I7fbc83f85d23676dc94db51dfda63dcacdf1fc19 Reviewed-on: https://go-review.googlesource.com/c/go/+/307235 Trust: Cherry Zhang <cherryyz@google.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Austin Clements <austin@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.