| commit | 96537d504423f332bfa2e8335a936a041c46206c | [log] [tgz] |
|---|---|---|
| author | Cherry Mui <cherryyz@google.com> | Tue Mar 25 16:55:54 2025 -0400 |
| committer | Gopher Robot <gobot@golang.org> | Thu Apr 10 08:35:38 2025 -0700 |
| tree | 3e73e1914447f2e9f9ff0a68db4b7f21ade8d33d | |
| parent | 7a2cfb70b01f069c2125adcf7126d7f3376cb8b7 [diff] |
[release-branch.go1.23] cmd/link: choose one with larger size for duplicated BSS symbols When two packages declare a variable with the same name (with linkname at least on one side), the linker will choose one as the actual definition of the symbol if one has content (i.e. a DATA symbol) and the other does not (i.e. a BSS symbol). When both have content, it is redefinition error. When neither has content, currently the choice is sort of arbitrary (depending on symbol loading order, etc. which are subject to change). One use case for that is that one wants to reference a symbol defined in another package, and the reference side just wants to see some of the fields, so it may be declared with a smaller type. In this case, we want to choose the one with the larger size as the true definition. Otherwise the code accessing the larger sized one may read/write out of bounds, corrupting the next variable. This CL makes the linker do so. Also include followup fix CL 661915. Fixes #73091. Updates #72032. Change-Id: I160aa9e0234702066cb8f141c186eaa89d0fcfed Reviewed-on: https://go-review.googlesource.com/c/go/+/660696 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Than McIntosh <thanm@golang.org> (cherry picked from commit 8f6c083d7bf68a766073c50ceb8ea405a3fe7bed) Reviewed-on: https://go-review.googlesource.com/c/go/+/662355 Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.