| commit | 902d8de79ed9bb6013cdb1952db1538bc1d10677 | [log] [tgz] |
|---|---|---|
| author | Cherry Zhang <cherryyz@google.com> | Tue May 26 20:02:43 2020 -0400 |
| committer | Cherry Zhang <cherryyz@google.com> | Wed May 27 15:26:40 2020 +0000 |
| tree | 04c7dd8533b1e3c2ec5faa63558decfc8247fcf8 | |
| parent | c0e8e405c02388fb8e7d3bea092f5aa8b19b2ad9 [diff] |
cmd/link: actually close the output file When the output file is mmap'd, OutBuf.Close currently munmap the file but doesn't actually close the file descriptor. This CL makes it actually close the FD. Change-Id: I053c5592ae95497228c50ce6a267b3b48f0af6d6 Reviewed-on: https://go-review.googlesource.com/c/go/+/235417 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
diff --git a/src/cmd/link/internal/ld/outbuf.go b/src/cmd/link/internal/ld/outbuf.go index 4ce2111..09162ae 100644 --- a/src/cmd/link/internal/ld/outbuf.go +++ b/src/cmd/link/internal/ld/outbuf.go
@@ -115,7 +115,6 @@ if out.isMmapped() { out.copyHeap() out.munmap() - return nil } if out.f == nil { return nil