Google Git
Sign in
go/go/8dcb3171f650e2f8fe68302cae0d6bf78b2e544a
commit
8dcb3171f650e2f8fe68302cae0d6bf78b2e544a
[log]
author
Jorropo <jorropo.pgm@gmail.com>
Mon Jun 29 07:36:37 2026 +0200
committer
Gopher Robot <gobot@golang.org>
Tue Jun 30 10:06:52 2026 -0700
tree
3e0acb389fc919be9676fb0913fbfa7bd87ed73f
parent
32334396912b43b765cfe82a9c70d165c5590244 [diff]
cmd/compile: fix misscompile in rewrite generic rules

We canonicalize *sh*x(32|16|8) x (Const*) to *sh*x64 x (Const64)
however for the shift type we were using the shift's type.

This is wrong since if we have let's say Rsh32x32 <uint32>
we would generate a Const64 with a type size of 4 (given it
takes the uint32 type).

This causes me confirmed crashes, maybe misscompilations too but
I didn't tried coming up with one.

Change-Id: Idcef7a371836524aa6649e13424431d716497860
Reviewed-on: https://go-review.googlesource.com/c/go/+/795240
Auto-Submit: Jorropo <jorropo.pgm@gmail.com>
Auto-Submit: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
2 files changed
tree: 3e0acb389fc919be9676fb0913fbfa7bd87ed73f
  1. .github/
  2. api/
  3. doc/
  4. lib/
  5. misc/
  6. src/
  7. test/
  8. .gitattributes
  9. .gitignore
  10. codereview.cfg
  11. CONTRIBUTING.md
  12. go.env
  13. LICENSE
  14. PATENTS
  15. README.md
  16. SECURITY.md
README.md

The Go Programming Language

Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.

Gopher image Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.

Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.

Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.

Download and Install

Binary Distributions

Official binary distributions are available at https://go.dev/dl/.

After downloading a binary release, visit https://go.dev/doc/install for installation instructions.

Install From Source

If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.

Contributing

Go is the work of thousands of contributors. We appreciate your help!

To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.

Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.