| commit | 87412a143051d63f4ce68900f4668b2a3fb5c4f2 | [log] [tgz] |
|---|---|---|
| author | Josh Bleecher Snyder <josharian@gmail.com> | Sat May 05 20:17:49 2018 -0700 |
| committer | Josh Bleecher Snyder <josharian@gmail.com> | Sun May 06 04:27:05 2018 +0000 |
| tree | ce015f6265fd4c86fb64f4eafbcaf8057d2579a3 | |
| parent | 5cf3e34f96f0ea975e0ce5fb8a5f3b036a916500 [diff] |
text/tabwriter: fix BenchmarkPyramid and BenchmarkRagged These were added in CL 106979. They were wrong. The correct impact of CL 106979 on these benchmarks is: name old time/op new time/op delta Pyramid/10-8 6.22µs ± 1% 5.68µs ± 0% -8.78% (p=0.000 n=15+13) Pyramid/100-8 275µs ± 1% 255µs ± 1% -7.30% (p=0.000 n=15+13) Pyramid/1000-8 25.6ms ± 1% 24.8ms ± 1% -2.88% (p=0.000 n=15+14) Ragged/10-8 8.98µs ± 1% 6.74µs ± 0% -24.98% (p=0.000 n=15+14) Ragged/100-8 85.3µs ± 0% 57.5µs ± 1% -32.51% (p=0.000 n=13+15) Ragged/1000-8 847µs ± 1% 561µs ± 1% -33.85% (p=0.000 n=14+15) name old alloc/op new alloc/op delta Pyramid/10-8 4.74kB ± 0% 4.88kB ± 0% +3.04% (p=0.000 n=15+15) Pyramid/100-8 379kB ± 0% 411kB ± 0% +8.50% (p=0.000 n=15+12) Pyramid/1000-8 35.3MB ± 0% 41.6MB ± 0% +17.68% (p=0.000 n=15+15) Ragged/10-8 4.82kB ± 0% 1.82kB ± 0% -62.13% (p=0.000 n=15+15) Ragged/100-8 45.4kB ± 0% 1.8kB ± 0% -95.98% (p=0.000 n=15+15) Ragged/1000-8 449kB ± 0% 2kB ± 0% -99.59% (p=0.000 n=15+15) name old allocs/op new allocs/op delta Pyramid/10-8 50.0 ± 0% 35.0 ± 0% -30.00% (p=0.000 n=15+15) Pyramid/100-8 704 ± 0% 231 ± 0% -67.19% (p=0.000 n=15+15) Pyramid/1000-8 10.0k ± 0% 2.1k ± 0% -79.52% (p=0.000 n=15+15) Ragged/10-8 60.0 ± 0% 19.0 ± 0% -68.33% (p=0.000 n=15+15) Ragged/100-8 511 ± 0% 19 ± 0% -96.28% (p=0.000 n=15+15) Ragged/1000-8 5.01k ± 0% 0.02k ± 0% -99.62% (p=0.000 n=15+15) This is an improvement over what was originally reported, except the increase in alloc/op for the Pyramid benchmarks. Change-Id: Ib2617c1288ce35f2c78e0172533d231b86e48bc2 Reviewed-on: https://go-review.googlesource.com/111643 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.