commit | 841e63e480ca2626e0cd0bbf8df31f8c6d8ee597 | [log] [tgz] |
---|---|---|
author | Bryan C. Mills <bcmills@google.com> | Mon Nov 20 15:20:58 2023 -0500 |
committer | Gopher Robot <gobot@golang.org> | Mon Nov 20 22:45:34 2023 +0000 |
tree | 3520de8e980150bf9678c4ffd64e81e23f754569 | |
parent | af1242932e121f510ad04282277740cceff2e550 [diff] |
cmd/go: don't warn about GOROOT equal to GOPATH when both are the empty string As of Go 1.19, runtime.GOROOT() reports the empty string if the binary was built with -trimpath. cmd/go/internal/cfg uses the path of the go command executable to reverse-engineer the correct GOROOT setting, but that means that cmd/go's "GOPATH set to GOROOT" warning needs to use cfg.GOROOT instead of runtime.GOROOT(). In addition, if we fail to find the GOROOT then there is no point in complaining about GOPATH also being empty: the missing GOROOT will stop everything right away anyway, so there is no point confusing the user with an additional warning about GOPATH. Updates #51461. Updates #18678. Updates #3207. Change-Id: Id7d0f4dc2f229c202dfda4e6e8af5dea909bb16f Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/543955 Reviewed-by: Michael Matloob <matloob@golang.org> Auto-Submit: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.