| commit | 7f9ee2ba5b3b60a4e71650abe5d94e0ef85720d1 | [log] [tgz] |
|---|---|---|
| author | Dmitry Panov <dop251@gmail.com> | Wed Dec 28 23:05:26 2022 +0000 |
| committer | Gopher Robot <gobot@golang.org> | Tue Jan 24 19:10:58 2023 +0000 |
| tree | b8ccb1d698007e6e561e0a99ed224e25278dbbf5 | |
| parent | 3900ba4baf0e3b309a55b5ac4dd25f709df09772 [diff] |
math: handle int64 overflows for odd integer exponents in Pow(-0, y) The existing implementation does a float64 to int64 conversion in order to check whether the number is odd, however it does not check for overflows. If an overflow occurs, the result is implementation-defined and while it happens to work on amd64 and i386, it produces an incorrect result on arm64 and possibly other architectures. This change fixes that and also avoids calling isOddInt altogether if the base is +0, because it's unnecessary. (I was considering avoiding the extra check if runtime.GOARCH is "amd64" or "i386", but I can't see this pattern being used anywhere outside the tests. And having separate files with build tags just for isOddInt() seems like an overkill) Fixes #57465 Change-Id: Ieb243796194412aa6b98fac05fd19766ca2413ef GitHub-Last-Rev: 3bfbd85c4cd6c5dc3d15239e180c99764a19ca88 GitHub-Pull-Request: golang/go#57494 Reviewed-on: https://go-review.googlesource.com/c/go/+/459815 Auto-Submit: Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org> TryBot-Bypass: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.