| commit | 79284c28734bf854f44106835b5578ead75eb547 | [log] [tgz] |
|---|---|---|
| author | Filippo Valsorda <filippo@golang.org> | Mon Mar 02 15:52:56 2020 -0500 |
| committer | Filippo Valsorda <filippo@golang.org> | Tue Mar 03 20:42:07 2020 +0000 |
| tree | 0918eb7157b3dddc012749370c9517d9080debd0 | |
| parent | 6c64b188a53afec79563cf4ad3c5bc373036d3ae [diff] |
[dev.boringcrypto] crypto/internal/boring: make accesses to RSA types with finalizers safer RSA key types have a finalizer that will free the underlying C value when the Go one is garbage collected. It's important that the finalizer doesn't run while a cgo call is using the underlying C value, so they require runtime.KeepAlive calls after each use. This is error prone, so replace it with a closure that provides access to the underlying C value and then automatically calls KeepAlive. AES, HMAC, and ECDSA also need KeepAlives, but they have much fewer call sites, so avoid the complexity for now. Change-Id: I6d6f38297cd1cf384a1639974d9739a939cbdbcc Reviewed-on: https://go-review.googlesource.com/c/go/+/221822 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Katie Hockman <katie@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.