commit | 6b89194c28e6c4a26b8d917a8c3e158a7eb0c169 | [log] [tgz] |
---|---|---|
author | Russ Cox <rsc@golang.org> | Wed Jul 11 14:31:17 2018 -0400 |
committer | Russ Cox <rsc@golang.org> | Thu Jul 12 00:10:07 2018 +0000 |
tree | 3bdb5e23e5a2e07a82db33015ca757aa8b914a4a | |
parent | 40bc0a77096be97fb7cf55e767b22d7babcc000b [diff] |
cmd/dist: enable build cache always GOCACHE=off is not a reliable signal of user intent. At startup the go command fills in an empty GOCACHE with the effective setting. If $HOME is set, then GOCACHE ends up somewhere in $HOME/.cache. But if $HOME is unset, then the go command sets GOCACHE=off explicitly. That environment is used for invoking "go tool dist". So if the machine has no $HOME, then go tool dist ends up with the cache disabled even though the user was not trying to disable the cache. This affects the linux-ppc64le builder, which appears to be unique among builders in not having $HOME set. So that builder is running with no build cache. Now that there is a cmd/go test that needs the cache to be on, the linux-ppc64le builder is failing. In the next release we intend to force the use of the build cache always. This CL is not doing that: it's only forcing the use of the build cache during all.bash, which won't affect the majority of our users (they run pre-build binary releases). If this is a problem we can roll it back and fix the linux-ppc64le builders some other way. While we're here, print a few more useful variables in 'go tool dist env' and sort the output. Change-Id: I66548aa8990d0794cbc0f2069b739ab1834898dd Reviewed-on: https://go-review.googlesource.com/123297 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.