commit 68cce4ab206586267fcfa9ac4ef3dc8396054e94
author Anthony Martin <ality@pbrane.org> Mon Sep 06 08:04:53 2010 +1000
committer Rob Pike <r@golang.org> Mon Sep 06 08:04:53 2010 +1000
tree 833965b66d7277368ecbfa5417f0078ff35c5390
parent d54b921c9baf19105d074896da98d6dbf3c9e219

fmt.Scan: fix integer overflow on 32-bit machines

R=r, rsc
CC=golang-dev
https://golang.org/cl/2144043

src/pkg/fmt/scan.go

diff --git a/src/pkg/fmt/scan.go b/src/pkg/fmt/scan.go
index afbbeb3..bd8af50 100644
--- a/src/pkg/fmt/scan.go
+++ b/src/pkg/fmt/scan.go
@@ -740,7 +740,7 @@
 	case *int32:
 		*v = int32(s.scanInt(verb, 32))
 	case *int64:
-		*v = s.scanInt(verb, intBits)
+		*v = s.scanInt(verb, 64)
 	case *uint:
 		*v = uint(s.scanUint(verb, intBits))
 	case *uint8:

src/pkg/fmt/scan_test.go

diff --git a/src/pkg/fmt/scan_test.go b/src/pkg/fmt/scan_test.go
index 9092789..569d2f5 100644
--- a/src/pkg/fmt/scan_test.go
+++ b/src/pkg/fmt/scan_test.go
@@ -183,6 +183,9 @@
 
 	// Custom scanner.
 	ScanTest{"  vvv ", &xVal, Xs("vvv")},
+
+	// Fixed bugs
+	ScanTest{"2147483648\n", &int64Val, int64(2147483648)}, // was: integer overflow
 }
 
 var scanfTests = []ScanfTest{