commit | 631402f142e52f535b66864ad1957ef39c78c704 | [log] [tgz] |
---|---|---|
author | Brad Fitzpatrick <bradfitz@golang.org> | Wed Jul 11 17:35:13 2018 +0000 |
committer | Brad Fitzpatrick <bradfitz@golang.org> | Wed Jul 11 19:20:39 2018 +0000 |
tree | 164d04203b9ec25b2e425cc9c25573f4bdb79877 | |
parent | 787ff17dea8ba869ad064e664edcdef4bc2935d7 [diff] |
net/http: fix rare Transport leak, remove incorrect defensive logic Remove some incorrect code that was present after since I added support for idle timeouts in CL 22670. This code actually caused a bug (a rare goroutine leak) rather than prevent a bogus connection reuse. The t.idleMu mutex already protects most the invariants, including an explicit Stop call. There's only one Stop call on that timer, and it's guarded by t.idleMu. What idleMu doesn't protect against is the timer firing on its own. But we don't need code to protect against that case because the goroutine that is created via AfterFunc when the timer fires already checks the invariants: // closeConnIfStillIdle closes the connection if it's still sitting idle. // This is what's called by the persistConn's idleTimer, and is run in its // own goroutine. func (pc *persistConn) closeConnIfStillIdle() { t := pc.t t.idleMu.Lock() defer t.idleMu.Unlock() if _, ok := t.idleLRU.m[pc]; !ok { // Not idle. return } (note the "Not idle." part). Tested by hand with the repro code from #25621. No more leaks. Fixes #25621 Change-Id: Idf011a4cb1fcd01f55a5a6269e4c0ee5f4446786 Reviewed-on: https://go-review.googlesource.com/123315 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.