| commit | 60cbff6f1906ec1bbc939acfb7cc97b18e639ce9 | [log] [tgz] |
|---|---|---|
| author | Roland Shoemaker <rolandshoemaker@gmail.com> | Mon May 11 16:21:54 2020 -0700 |
| committer | Filippo Valsorda <filippo@golang.org> | Fri Jun 05 16:50:47 2020 +0000 |
| tree | 4e1ece7dfcacc7f50f79977c82f50ae54e0a234b | |
| parent | a38f29ad613a56b2ad5b3f109a404c06a7a92fed [diff] |
crypto/x509: match cgo and Apple behavior in domain fallback of macOS roots This change makes the direct call darwin loadSystemRoots implementation match the existing cgo implementation, which in turn _mostly_ matches the Apple implementation. The main change here is that when SecTrustSettingsCopyTrustSettings the error is ignored, and can either cause a fallback to check admin trust settings, or cause the certificate to be marked kSecTrustSettingsResultUnspecified. As well as updating the implementation to match the cgo one, this change also updates the documentation of how the fallbacks work and how they match the Apple implementations. References are made to the Apple source where appropriate. This change does not update the existing comments in the cgo implementation, since the goal is to delete that code once the direct call implementation is matured. Updates #38888 Change-Id: Id0344ea9d2eede3b715f341e9cbd3c1c661b7a90 Reviewed-on: https://go-review.googlesource.com/c/go/+/233360 Run-TryBot: Filippo Valsorda <filippo@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.