| commit | 586d0755e2cd6a51f0837c6b7748e93d58b966f1 | [log] [tgz] |
|---|---|---|
| author | Cherry Zhang <cherryyz@google.com> | Mon May 18 18:20:18 2020 -0400 |
| committer | Cherry Zhang <cherryyz@google.com> | Tue May 19 14:53:39 2020 +0000 |
| tree | 3d1592610fba5fc3eee6c068623c1e113af9b0ef | |
| parent | b8c5d6871f7a0799749537daa4a27491a369a4f7 [diff] |
[dev.link] cmd/link: only do name expansion when needed Most Go objects are compiled with known package path, so the symbol name is already fully expanded. Nevertheless, currently in the linker strings.Replace is called unconditionally, and most of the time it doesn't do anything. This CL records a per-object flag in the object file, and do the name expansion only when the name is not expanded at compile time. This gives small speedups for the linker. Linking cmd/compile: name old time/op new time/op delta Loadlib 35.1ms ± 2% 32.8ms ± 4% -6.43% (p=0.008 n=5+5) Symtab 15.8ms ± 2% 14.0ms ± 8% -11.45% (p=0.008 n=5+5) TotalTime 399ms ± 1% 385ms ± 2% -3.63% (p=0.008 n=5+5) Change-Id: I735084971a051cd9be4284ad294c284cd5b545f4 Reviewed-on: https://go-review.googlesource.com/c/go/+/234490 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jeremy Faller <jeremy@golang.org> Reviewed-by: Than McIntosh <thanm@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.